diff options
| author | Corey Farwell <coreyf@rwell.org> | 2015-08-22 10:22:47 -0400 |
|---|---|---|
| committer | Corey Farwell <coreyf@rwell.org> | 2015-08-22 10:22:47 -0400 |
| commit | 5bf262770f5ff6607bc766b487131cda3c5e22b5 (patch) | |
| tree | 026636032f39786d66c74a934b5de648ff627a9b /components/script/dom/bindings/codegen/CodegenRust.py | |
| parent | 3a48e04caffa4ba25854a4190883d1985845a359 (diff) | |
| download | servo-5bf262770f5ff6607bc766b487131cda3c5e22b5.tar.gz servo-5bf262770f5ff6607bc766b487131cda3c5e22b5.zip | |
Don't use `is` operatory to compare Python strings
`is` checks identity. `==` checks value. I can't think of a reason why
we would want the former in these scenarios.
More info:
* http://stackoverflow.com/a/1504742
* https://docs.python.org/2/reference/expressions.html#is
Diffstat (limited to 'components/script/dom/bindings/codegen/CodegenRust.py')
| -rw-r--r-- | components/script/dom/bindings/codegen/CodegenRust.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/components/script/dom/bindings/codegen/CodegenRust.py b/components/script/dom/bindings/codegen/CodegenRust.py index b4ed22fb447..c8eda80834f 100644 --- a/components/script/dom/bindings/codegen/CodegenRust.py +++ b/components/script/dom/bindings/codegen/CodegenRust.py @@ -1583,7 +1583,7 @@ class CGIndenter(CGThing): def define(self): defn = self.child.define() - if defn is not "": + if defn != "": return re.sub(lineStartDetector, self.indent, defn) else: return defn @@ -3641,7 +3641,7 @@ class ClassMethod(ClassItem): 'override': ' MOZ_OVERRIDE' if self.override else '', 'args': args, 'body': body, - 'visibility': self.visibility + ' ' if self.visibility is not 'priv' else '' + 'visibility': self.visibility + ' ' if self.visibility != 'priv' else '' }) def define(self, cgClass): |