From 5bf262770f5ff6607bc766b487131cda3c5e22b5 Mon Sep 17 00:00:00 2001 From: Corey Farwell Date: Sat, 22 Aug 2015 10:22:47 -0400 Subject: Don't use `is` operatory to compare Python strings `is` checks identity. `==` checks value. I can't think of a reason why we would want the former in these scenarios. More info: * http://stackoverflow.com/a/1504742 * https://docs.python.org/2/reference/expressions.html#is --- components/script/dom/bindings/codegen/CodegenRust.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'components/script/dom/bindings/codegen/CodegenRust.py') diff --git a/components/script/dom/bindings/codegen/CodegenRust.py b/components/script/dom/bindings/codegen/CodegenRust.py index b4ed22fb447..c8eda80834f 100644 --- a/components/script/dom/bindings/codegen/CodegenRust.py +++ b/components/script/dom/bindings/codegen/CodegenRust.py @@ -1583,7 +1583,7 @@ class CGIndenter(CGThing): def define(self): defn = self.child.define() - if defn is not "": + if defn != "": return re.sub(lineStartDetector, self.indent, defn) else: return defn @@ -3641,7 +3641,7 @@ class ClassMethod(ClassItem): 'override': ' MOZ_OVERRIDE' if self.override else '', 'args': args, 'body': body, - 'visibility': self.visibility + ' ' if self.visibility is not 'priv' else '' + 'visibility': self.visibility + ' ' if self.visibility != 'priv' else '' }) def define(self, cgClass): -- cgit v1.2.3