diff options
| author | Thiemo Kreuz <thiemo.kreuz@wikimedia.de> | 2019-09-17 16:31:49 +0200 |
|---|---|---|
| committer | Thiemo Kreuz (WMDE) <thiemo.kreuz@wikimedia.de> | 2019-09-19 15:35:23 +0000 |
| commit | 32a429e8c455688b9613660b91db51dcf4eb8c19 (patch) | |
| tree | 9ebc7a71e4d4aed4166a802d4f60f98beaab4f11 /tests/phpunit/unit/includes/diff/DiffOpTest.php | |
| parent | 78fc6fe8659f1b7d67e7ca2e40640415a9d58ddc (diff) | |
| download | mediawikicore-32a429e8c455688b9613660b91db51dcf4eb8c19.tar.gz mediawikicore-32a429e8c455688b9613660b91db51dcf4eb8c19.zip | |
tests: Prefer assertSame() when comparing the integer 0
assertSame() is guaranteed to not do any type conversion. This can be
critical when acciden tially comparing, for example, 0 to 0.0.
Change-Id: Iffcc9bda69573623ba14af655dcd697d0fcce525
Diffstat (limited to 'tests/phpunit/unit/includes/diff/DiffOpTest.php')
| -rw-r--r-- | tests/phpunit/unit/includes/diff/DiffOpTest.php | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tests/phpunit/unit/includes/diff/DiffOpTest.php b/tests/phpunit/unit/includes/diff/DiffOpTest.php index 4e1aced7a6d4..17487acbca22 100644 --- a/tests/phpunit/unit/includes/diff/DiffOpTest.php +++ b/tests/phpunit/unit/includes/diff/DiffOpTest.php @@ -50,7 +50,7 @@ class DiffOpTest extends \MediaWikiUnitTestCase { */ public function testNorig() { $obj = new FakeDiffOp(); - $this->assertEquals( 0, $obj->norig() ); + $this->assertSame( 0, $obj->norig() ); $obj->orig = [ 'foo' ]; $this->assertEquals( 1, $obj->norig() ); } @@ -60,7 +60,7 @@ class DiffOpTest extends \MediaWikiUnitTestCase { */ public function testNclosing() { $obj = new FakeDiffOp(); - $this->assertEquals( 0, $obj->nclosing() ); + $this->assertSame( 0, $obj->nclosing() ); $obj->closing = [ 'foo' ]; $this->assertEquals( 1, $obj->nclosing() ); } |