From 32a429e8c455688b9613660b91db51dcf4eb8c19 Mon Sep 17 00:00:00 2001 From: Thiemo Kreuz Date: Tue, 17 Sep 2019 16:31:49 +0200 Subject: tests: Prefer assertSame() when comparing the integer 0 assertSame() is guaranteed to not do any type conversion. This can be critical when acciden tially comparing, for example, 0 to 0.0. Change-Id: Iffcc9bda69573623ba14af655dcd697d0fcce525 --- tests/phpunit/unit/includes/diff/DiffOpTest.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'tests/phpunit/unit/includes/diff/DiffOpTest.php') diff --git a/tests/phpunit/unit/includes/diff/DiffOpTest.php b/tests/phpunit/unit/includes/diff/DiffOpTest.php index 4e1aced7a6d4..17487acbca22 100644 --- a/tests/phpunit/unit/includes/diff/DiffOpTest.php +++ b/tests/phpunit/unit/includes/diff/DiffOpTest.php @@ -50,7 +50,7 @@ class DiffOpTest extends \MediaWikiUnitTestCase { */ public function testNorig() { $obj = new FakeDiffOp(); - $this->assertEquals( 0, $obj->norig() ); + $this->assertSame( 0, $obj->norig() ); $obj->orig = [ 'foo' ]; $this->assertEquals( 1, $obj->norig() ); } @@ -60,7 +60,7 @@ class DiffOpTest extends \MediaWikiUnitTestCase { */ public function testNclosing() { $obj = new FakeDiffOp(); - $this->assertEquals( 0, $obj->nclosing() ); + $this->assertSame( 0, $obj->nclosing() ); $obj->closing = [ 'foo' ]; $this->assertEquals( 1, $obj->nclosing() ); } -- cgit v1.2.3