diff options
| author | Lucas Werkmeister <lucas.werkmeister@wikimedia.de> | 2024-06-10 16:50:41 +0200 |
|---|---|---|
| committer | Lucas Werkmeister <lucas.werkmeister@wikimedia.de> | 2024-06-10 16:50:41 +0200 |
| commit | a5c1fc67ee53eeea2f363abcf7b38aabb4ec6973 (patch) | |
| tree | 9193255b8941c52895a0f6d14e67bb5f41622092 /tests/api-testing/REST/Transform.js | |
| parent | 4c673f1913ad5727c22792d95688be4ebc76d8dd (diff) | |
| download | mediawikicore-a5c1fc67ee53eeea2f363abcf7b38aabb4ec6973.tar.gz mediawikicore-a5c1fc67ee53eeea2f363abcf7b38aabb4ec6973.zip | |
api-testing: Further increase ETag number in transform tests
Change I5521b7652f (commit 682a19e9f6) increased the number by roughly
one order of magnitude, which leaves me nervous that the tests might
start failing again if enough other tests are run in the same wiki to
let the increased revision IDs exist. Let’s bump it further to make that
much less likely (though not impossible).
1219844647 is an arbitrary large number; my intention in choosing a
random-looking number (rather than, say, 1234567890) is that it’s easier
to search for, both in codesearch and in commit messages, if it should
ever pop up in an error message.
Bug: T366142
Change-Id: I8186d9d46bc2a3f5ec04b38aab5cbe85e609835a
Follows-Up: I5521b7652faca9821fa08a9987a9452a4c555203
Diffstat (limited to 'tests/api-testing/REST/Transform.js')
| -rw-r--r-- | tests/api-testing/REST/Transform.js | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/tests/api-testing/REST/Transform.js b/tests/api-testing/REST/Transform.js index fd9623aa1db5..fb23e966152e 100644 --- a/tests/api-testing/REST/Transform.js +++ b/tests/api-testing/REST/Transform.js @@ -2361,7 +2361,7 @@ describe( '/transform/ endpoint', function () { it( '/transform/ should refuse non-matching ETags in header', async () => { const { status, text } = await client.req .post( endpointPrefix + `/transform/html/to/wikitext/${ page }/${ revid }` ) - .set( 'If-Match', '"13337/deadbeef"' ) + .set( 'If-Match', '"1219844647/deadbeef"' ) .send( { html: '<p>hello</p>' } ); @@ -2374,7 +2374,7 @@ describe( '/transform/ endpoint', function () { .post( endpointPrefix + `/transform/html/to/wikitext/${ page }` ) .send( { html: '<p>hello</p>', - original: { etag: '"13337/deadbeef"' } + original: { etag: '"1219844647/deadbeef"' } } ); assert.deepEqual( status, 412, text ); @@ -2412,7 +2412,7 @@ describe( '/transform/ endpoint', function () { // request page HTML, but do not set 'stash' parameter! const transformResponse = await client.req .post( endpointPrefix + '/transform/html/to/wikitext/' ) - .set( 'If-Match', '"12345/dummy"' ) + .set( 'If-Match', '"1219844647/dummy"' ) .send( { html: '<p>test</p>' } ); @@ -2453,7 +2453,7 @@ describe( '/transform/ endpoint', function () { .send( { html: '<p>test</p>', original: { - renderid: '"12345/dummy"' + renderid: '"1219844647/dummy"' } } ); |