From a5c1fc67ee53eeea2f363abcf7b38aabb4ec6973 Mon Sep 17 00:00:00 2001 From: Lucas Werkmeister Date: Mon, 10 Jun 2024 16:50:41 +0200 Subject: api-testing: Further increase ETag number in transform tests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Change I5521b7652f (commit 682a19e9f6) increased the number by roughly one order of magnitude, which leaves me nervous that the tests might start failing again if enough other tests are run in the same wiki to let the increased revision IDs exist. Let’s bump it further to make that much less likely (though not impossible). 1219844647 is an arbitrary large number; my intention in choosing a random-looking number (rather than, say, 1234567890) is that it’s easier to search for, both in codesearch and in commit messages, if it should ever pop up in an error message. Bug: T366142 Change-Id: I8186d9d46bc2a3f5ec04b38aab5cbe85e609835a Follows-Up: I5521b7652faca9821fa08a9987a9452a4c555203 --- tests/api-testing/REST/Transform.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'tests/api-testing/REST/Transform.js') diff --git a/tests/api-testing/REST/Transform.js b/tests/api-testing/REST/Transform.js index fd9623aa1db5..fb23e966152e 100644 --- a/tests/api-testing/REST/Transform.js +++ b/tests/api-testing/REST/Transform.js @@ -2361,7 +2361,7 @@ describe( '/transform/ endpoint', function () { it( '/transform/ should refuse non-matching ETags in header', async () => { const { status, text } = await client.req .post( endpointPrefix + `/transform/html/to/wikitext/${ page }/${ revid }` ) - .set( 'If-Match', '"13337/deadbeef"' ) + .set( 'If-Match', '"1219844647/deadbeef"' ) .send( { html: '

hello

' } ); @@ -2374,7 +2374,7 @@ describe( '/transform/ endpoint', function () { .post( endpointPrefix + `/transform/html/to/wikitext/${ page }` ) .send( { html: '

hello

', - original: { etag: '"13337/deadbeef"' } + original: { etag: '"1219844647/deadbeef"' } } ); assert.deepEqual( status, 412, text ); @@ -2412,7 +2412,7 @@ describe( '/transform/ endpoint', function () { // request page HTML, but do not set 'stash' parameter! const transformResponse = await client.req .post( endpointPrefix + '/transform/html/to/wikitext/' ) - .set( 'If-Match', '"12345/dummy"' ) + .set( 'If-Match', '"1219844647/dummy"' ) .send( { html: '

test

' } ); @@ -2453,7 +2453,7 @@ describe( '/transform/ endpoint', function () { .send( { html: '

test

', original: { - renderid: '"12345/dummy"' + renderid: '"1219844647/dummy"' } } ); -- cgit v1.2.3