diff options
| author | Bryan Davis <bd808@wikimedia.org> | 2017-11-19 17:36:54 -0700 |
|---|---|---|
| committer | Bryan Davis <bd808@wikimedia.org> | 2017-11-21 21:34:16 -0700 |
| commit | 9e34eeff23fdd46a8e9bddfbab39d45eab232827 (patch) | |
| tree | 8bc5d4bdd2efc8ce68d2c605f10f1bfa7d88de3a /maintenance/populateImageSha1.php | |
| parent | 708e8e9dee4523997a2dfe73e312db18725e782b (diff) | |
| download | mediawikicore-9e34eeff23fdd46a8e9bddfbab39d45eab232827.tar.gz mediawikicore-9e34eeff23fdd46a8e9bddfbab39d45eab232827.zip | |
Maintenance: add fatalError() method
Deprecate the second argument to Maintenance::error() in favor of a new
Maintenance::fatalError() method. This is intended to make it easier to
review flow control in maintenance scripts.
Change-Id: I75699008638f7e99b11210c7bb9e2e131fca7c9e
Diffstat (limited to 'maintenance/populateImageSha1.php')
| -rw-r--r-- | maintenance/populateImageSha1.php | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/maintenance/populateImageSha1.php b/maintenance/populateImageSha1.php index 2735a1ed8d82..84b65ee7ac98 100644 --- a/maintenance/populateImageSha1.php +++ b/maintenance/populateImageSha1.php @@ -76,9 +76,7 @@ class PopulateImageSha1 extends LoggedUpdateMaintenance { __METHOD__ ); if ( !$res ) { - $this->error( "No such file: $file", true ); - - return false; + $this->fatalError( "No such file: $file" ); } $this->output( "Populating img_sha1 field for specified files\n" ); } else { |