From 9e34eeff23fdd46a8e9bddfbab39d45eab232827 Mon Sep 17 00:00:00 2001 From: Bryan Davis Date: Sun, 19 Nov 2017 17:36:54 -0700 Subject: Maintenance: add fatalError() method Deprecate the second argument to Maintenance::error() in favor of a new Maintenance::fatalError() method. This is intended to make it easier to review flow control in maintenance scripts. Change-Id: I75699008638f7e99b11210c7bb9e2e131fca7c9e --- maintenance/populateImageSha1.php | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'maintenance/populateImageSha1.php') diff --git a/maintenance/populateImageSha1.php b/maintenance/populateImageSha1.php index 2735a1ed8d82..84b65ee7ac98 100644 --- a/maintenance/populateImageSha1.php +++ b/maintenance/populateImageSha1.php @@ -76,9 +76,7 @@ class PopulateImageSha1 extends LoggedUpdateMaintenance { __METHOD__ ); if ( !$res ) { - $this->error( "No such file: $file", true ); - - return false; + $this->fatalError( "No such file: $file" ); } $this->output( "Populating img_sha1 field for specified files\n" ); } else { -- cgit v1.2.3