diff options
| author | Aaron Schulz <aschulz@wikimedia.org> | 2019-05-09 17:59:04 -0700 |
|---|---|---|
| committer | Aaron Schulz <aschulz@wikimedia.org> | 2019-05-09 18:27:02 -0700 |
| commit | bc272498298816c3095dda19dc9602629590484b (patch) | |
| tree | 32e512defad6de7ab46de4627b151d8330db12cc /includes/specials/SpecialWatchlist.php | |
| parent | 8f7ee6a4cfa002cb3025857093d44e0fb9529c76 (diff) | |
| download | mediawikicore-bc272498298816c3095dda19dc9602629590484b.tar.gz mediawikicore-bc272498298816c3095dda19dc9602629590484b.zip | |
watchlist: fix nonsensical timestamp/boolean comparisons in EnhancedRecentChanges
Also fix bug where the "changes since last visit" counter failed to show for pages
where their entire history is still in recent changes. Although the "new" flag is
set for the RCCacheEntry block, there can still be multiple revisions since the
last one seen by the user. This change accounts for that case.
Bug: T218511
Change-Id: I92060bd26d8642937cad7f8c1ace3c5e066790be
Diffstat (limited to 'includes/specials/SpecialWatchlist.php')
| -rw-r--r-- | includes/specials/SpecialWatchlist.php | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/includes/specials/SpecialWatchlist.php b/includes/specials/SpecialWatchlist.php index 1ef11b5ce70c..56f5c8fdac22 100644 --- a/includes/specials/SpecialWatchlist.php +++ b/includes/specials/SpecialWatchlist.php @@ -554,6 +554,9 @@ class SpecialWatchlist extends ChangesListSpecialPage { $rc->numberofWatchingusers = 0; } + // XXX: this treats pages with no unseen changes as "not on the watchlist" since + // everything is on the watchlist and it is an easy way to make pages with unseen + // changes appear bold. @TODO: clean this up. $changeLine = $list->recentChangesLine( $rc, $unseen, $counter ); if ( $changeLine !== false ) { $s .= $changeLine; |