aboutsummaryrefslogtreecommitdiffstats
path: root/includes/specials/SpecialWatchlist.php
diff options
context:
space:
mode:
authorAaron Schulz <aschulz@wikimedia.org>2019-05-09 17:37:58 -0700
committerAaron Schulz <aschulz@wikimedia.org>2019-05-09 17:44:16 -0700
commit8f7ee6a4cfa002cb3025857093d44e0fb9529c76 (patch)
tree4a986e27a8d4346b69893e864a1eafb34635a4da /includes/specials/SpecialWatchlist.php
parentfc0c1623c86d85d3b2b86c4b9d86bd119144e367 (diff)
downloadmediawikicore-8f7ee6a4cfa002cb3025857093d44e0fb9529c76.tar.gz
mediawikicore-8f7ee6a4cfa002cb3025857093d44e0fb9529c76.zip
watchlist: cleanup various method/variable names and comments in watchlist/store code
Change-Id: I70a55d5b4ea38f92132a15da3feb314b6b5bb013
Diffstat (limited to 'includes/specials/SpecialWatchlist.php')
-rw-r--r--includes/specials/SpecialWatchlist.php8
1 files changed, 4 insertions, 4 deletions
diff --git a/includes/specials/SpecialWatchlist.php b/includes/specials/SpecialWatchlist.php
index 812f1b00ab5c..1ef11b5ce70c 100644
--- a/includes/specials/SpecialWatchlist.php
+++ b/includes/specials/SpecialWatchlist.php
@@ -865,16 +865,16 @@ class SpecialWatchlist extends ChangesListSpecialPage {
* @return bool User viewed the revision or a newer one
*/
protected function isChangeEffectivelySeen( RecentChange $rc ) {
- $lastVisitTs = $this->getLatestSeenTimestampIfHasUnseen( $rc );
+ $firstUnseen = $this->getLatestNotificationTimestamp( $rc );
- return $lastVisitTs === null || $lastVisitTs > $rc->getAttribute( 'rc_timestamp' );
+ return ( $firstUnseen === null || $firstUnseen > $rc->getAttribute( 'rc_timestamp' ) );
}
/**
* @param RecentChange $rc
- * @return string|null TS_MW timestamp or null if all revision were seen
+ * @return string|null TS_MW timestamp of first unseen revision or null if there isn't one
*/
- private function getLatestSeenTimestampIfHasUnseen( RecentChange $rc ) {
+ private function getLatestNotificationTimestamp( RecentChange $rc ) {
return $this->watchStore->getLatestNotificationTimestamp(
$rc->getAttribute( 'wl_notificationtimestamp' ),
$rc->getPerformer(),