diff options
| author | Erik Bernhardson <ebernhardson@wikimedia.org> | 2016-12-07 21:04:53 -0800 |
|---|---|---|
| committer | Erik Bernhardson <ebernhardson@wikimedia.org> | 2016-12-12 10:15:05 -0800 |
| commit | d67197fa116acc366419faedeeacd91158a98f8b (patch) | |
| tree | e61e97bf32cdb5f83e236b6e25948b8fb7fd6a19 /includes/Revision.php | |
| parent | f5b4bd19b2719e039a8b6a9ec35f88c1385abca0 (diff) | |
| download | mediawikicore-d67197fa116acc366419faedeeacd91158a98f8b.tar.gz mediawikicore-d67197fa116acc366419faedeeacd91158a98f8b.zip | |
Cleanup some incorrect return annotations
Most of these are simply changing annotations to reflect
reality. If a function can return false to indicate failure
the @return should indicate it.
Some are fixing preg_match calls, preg match returns 1, 0 or false,
but the functions all claim to return booleans.
This is far from all the incorrect return types in mediawiki, there
are around 250 detected by phan, but have to start somewhere.
Change-Id: I1bbdfee6190747bde460f8a7084212ccafe169ef
Diffstat (limited to 'includes/Revision.php')
| -rw-r--r-- | includes/Revision.php | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/includes/Revision.php b/includes/Revision.php index b812191398ab..a74501f5ef07 100644 --- a/includes/Revision.php +++ b/includes/Revision.php @@ -874,7 +874,7 @@ class Revision implements IDBAccessObject { /** * Fetch revision's user id without regard for the current user's permissions * - * @return string + * @return int * @deprecated since 1.25, use getUser( Revision::RAW ) */ public function getRawUser() { @@ -1269,7 +1269,7 @@ class Revision implements IDBAccessObject { * (same as the the wiki $row was loaded from) or false to indicate the local * wiki (this is the default). Otherwise, it must be a symbolic wiki database * identifier as understood by the LoadBalancer class. - * @return string Text the text requested or false on failure + * @return string|false Text the text requested or false on failure */ public static function getRevisionText( $row, $prefix = 'old_', $wiki = false ) { |