aboutsummaryrefslogtreecommitdiffstats
path: root/includes/Revision.php
diff options
context:
space:
mode:
authorErik Bernhardson <ebernhardson@wikimedia.org>2016-06-30 17:11:52 -0700
committerErik Bernhardson <ebernhardson@wikimedia.org>2016-12-07 20:04:01 -0800
commitf5b4bd19b2719e039a8b6a9ec35f88c1385abca0 (patch)
tree8066a5f6f504aa23cd906e98eb54194cce36f146 /includes/Revision.php
parent90538900208d227c360613cda8c7904ce2e9dacb (diff)
downloadmediawikicore-f5b4bd19b2719e039a8b6a9ec35f88c1385abca0.tar.gz
mediawikicore-f5b4bd19b2719e039a8b6a9ec35f88c1385abca0.zip
Add configuration for running etsy/phan against core
Adds the necessary configuration and stubs for phan static analysis to run against mediawiki core. A variety of fixes have been applied to core recently such with this current configuration we are completely passing, except for one issue with a bug in Phan (https://github.com/etsy/phan/issues/286) In it's current configuration Phan will detect fatal errors trying to access non existant classes, undefined method calls, and other errors. The analysis can be expanded as we cleanup more of the codebase. This is in preparation for working on getting the CI to run phan as part of the review process. I have found phan to be usefull in CirrusSearch (although with stricter config) for catching bugs and I think it could help in core as well. We arn't too far from being able to disable `null_casts_as_any_type`, there are only a few classes that need adjusting. Lots more work needs to be done to reduce `minimum_severity` from 10 to 5 (normal) or 0 (low). Change-Id: Iafd55b1380f37d7b0d195eed081f8042166690e8
Diffstat (limited to 'includes/Revision.php')
0 files changed, 0 insertions, 0 deletions