| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
| |
|
|
|
|
| |
into_string has been removed from Rust.
|
|
|
|
| |
Update rust-azure to f4a02f3f621b0a994a20d42e438371a87c62f898.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
through display list building.
The old `flow_origin` concept was ill-defined (sometimes the border box
plus the flow origin, sometimes including horizontal margins and
sometimes not, sometimes including relative position and sometimes not),
leading to brittleness and test failures. This commit reworks the logic
to always pass border box origins in during display list building.
|
| |
|
| |
|
| |
|
|
|
|
| |
`caption-side` is used by 4% of pages by number of loads.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
The exact rendering is ill-spec'd. Some things are ugly (especially the
width and height of list style images) but they are infrequently used
and I believe this implementation matches the spec. Numeric lists are
not supported yet, since they will require a separate layout pass.
The implementation is a subclass of `BlockFlow`, on advice from Robert
O'Callahan.
|
|
|
|
|
|
| |
Addresses reviews
More review addressing
|
| |
|
|
|
|
| |
Closes #4196.
|
| |
|
| |
|
|
|
|
| |
Fixes #3724.
|
|
|
|
|
|
| |
out-of-flow" and "reconstruct flow" damage bits.
This is needed for good performance on the maze solver.
|
|
|
|
|
|
| |
flags to avoid virtual calls.
These were showing up really high in the maze solver profile.
|
|\
| |
| |
| |
| |
| |
| |
| | |
Avoids total reflow of the entire document on the maze solver.
I have tested Wikipedia reflow and it still works.
r? @cgaebel
|
| |
| |
| |
| | |
Avoids total reflow of the entire document on the maze solver.
|
|\ \
| | |
| | |
| | | |
r? @glennw
|
| |/
| |
| |
| | |
the time.
|
|/
|
|
| |
These should have no effect on functionality.
|
|
|
|
| |
16% performance improvement in layout (!)
|
|
|
|
|
|
|
| |
construction to avoid cloning and moving flows so much.
Besides amounting to a 5%-10% win on a page with a lot of text, this
simplifies and refactors the text layout code.
|
|
|
|
| |
turned on.
|
| |
|
|
|
|
|
|
|
|
| |
This also adds some extra debugging infrastructure which I found useful tracking
this bug down. A regression in the br reftests is also uncovered by this patch,
which I'll work on fixing next.
r? @pcwalton
|
|
|
|
|
|
| |
This implements fragment merging, in order to incrementally reflow linebroken
text. This makes the `whitespace_pre.html` reftest pass with incremental reflow
turned on with `-i`.
|
|
|
|
|
| |
This patch switches FlowRefs to using the Deref and DerefMut traits, instead of
the custom `get` and `get_mut` functions.
|
|\
| |
| |
| |
| |
| | |
This also hides the not-yet-working parts of incremental reflow behind a runtime
flag. As I get the failing reftests passing, I'll send pull requests for them one
by one.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
match L. David Baron's work-in-progress specification.
http://dbaron.org/css/intrinsic/
Column spans are not yet supported.
This effectively adds support for percentage widths, and it also fixes
many bugs, improving the layout of Google and Wikipedia.
|
| |
| |
| |
| |
| |
| |
| |
| | |
matching, and use it for `<input size>` and `<td width>`.
This implements a general framework for legacy presentational attributes
to the DOM and style calculation, so that adding more of them later will
be straightforward.
|
|/
|
|
| |
75% improvement in style recalc for Guardians of the Galaxy.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a separate `ClipDisplayItem`.
We push down clipping areas during absolute position calculation. This
makes display items into a flat list, improving cache locality. It
dramatically simplifies the code all around.
Because we need to push down clip rects even for absolutely-positioned
children of non-absolutely-positioned flows, this patch alters the
parallel traversal to compute absolute positions for
absolutely-positioned children at the same time it computes absolute
positions for other children. This doesn't seem to break anything either
in theory (since the overall order remains correct) or in practice. It
simplifies the parallel traversal code quite a bit.
See the relevant Gecko bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=615734
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch puts in the initial framework for incremental reflow. Nodes' styles
are no longer recalculated unless the node has changed.
I've been hacking on the general problem of incremental reflow for the past
couple weeks, and I've yet to get a full implementation that actually passes all
the reftests + wikipedia + cnn. Therefore, I'm going to try to land the different
parts of it one by one.
This patch only does incremental style recalc, without incremental flow
construction, inline-size bubbling, reflow, or display lists. Those will be coming
in that order as I finish them.
At least with this strategy, I can land a working version of incremental reflow,
even if not yet complete.
r? @pcwalton
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
absolutely-positioned elements declared with `display: inline`.
Although the computed `display` property of elements with `position:
absolute` is `block`, `position: absolute; display: inline` can still
behave differently from `position: absolute; display: block`. This is
because the hypothetical box for `position: absolute` can be at the
position it would have been if it had `display: inline`. CSS 2.1 §
10.3.7 describes this case in a parenthetical:
"The static-position containing block is the containing block of a
hypothetical box that would have been the first box of the element if
its specified 'position' value had been 'static' and its specified
'float' had been 'none'. (Note that due to the rules in section 9.7 this
hypothetical calculation might require also assuming a different
computed value for 'display'.)"
To handle this, I had to change both style computation and layout. For
the former, I added an internal property
`-servo-display-for-hypothetical-box`, which stores the `display` value
supplied by the author, before the computed value is calculated. Flow
construction now uses this value.
As for layout, implementing the proper behavior is tricky because the
position of an inline fragment in the inline direction cannot be
determined until height assignment, which is a parallelism hazard
because in parallel layout widths are computed before heights. However,
in this particular case we can avoid the parallelism hazard because the
inline direction of a hypothetical box only affects the layout if an
absolutely-positioned element is unconstrained in the inline direction.
Therefore, we can just lay out such absolutely-positioned elements with
a bogus inline position and fix it up once the true inline position of
the hypothetical box is computed. The name for this fix-up process is
"late computation of inline position" (and the corresponding fix-up for
the block position is called "late computation of block position").
This improves the header on /r/rust.
|
| |
|
|
|
|
| |
radio buttons. Switching to the glyph 0 for the average advance width.
|
|
|
|
| |
Implement simple interaction for checkboxes and radio buttons.
|
| |
|
|
|
|
|
|
| |
This improves the static correctness of layout's use of DOM nodes.
Fixes #2595.
|
|\
| |
| |
| |
| |
| | |
layout: Support any `display` property in generated content, and allow
Reviewed-by: glennw
|