aboutsummaryrefslogtreecommitdiffstats
path: root/components/layout/construct.rs
Commit message (Collapse)AuthorAgeFilesLines
* Remove InputFragmentCameron Zwarich2014-11-031-4/+2
| | | | Fixes #3724.
* layout: Make incremental reflow more fine-grained by introducing "reflowPatrick Walton2014-10-311-2/+41
| | | | | | out-of-flow" and "reconstruct flow" damage bits. This is needed for good performance on the maze solver.
* layout: Promote absolute positioning, floatedness, and clearance intoPatrick Walton2014-10-281-5/+4
| | | | | | flags to avoid virtual calls. These were showing up really high in the maze solver profile.
* auto merge of #3841 : pcwalton/servo/removing-whitespace-damage, r=cgaebelbors-servo2014-10-281-18/+6
|\ | | | | | | | | | | | | | | Avoids total reflow of the entire document on the maze solver. I have tested Wikipedia reflow and it still works. r? @cgaebel
| * layout: Stop adding damage when removing whitespace.Patrick Walton2014-10-281-18/+6
| | | | | | | | Avoids total reflow of the entire document on the maze solver.
* | auto merge of #3840 : pcwalton/servo/ib-splits-linked-list, r=glennwbors-servo2014-10-281-5/+5
|\ \ | | | | | | | | | r? @glennw
| * | layout: Put {ib} splits into a linked list so we stop copying them allPatrick Walton2014-10-281-5/+5
| |/ | | | | | | the time.
* / layout: Make some formatting cleanups.Patrick Walton2014-10-281-6/+6
|/ | | | These should have no effect on functionality.
* layout: Shrink fragments down from 448 bytes down to 128 bytes.Patrick Walton2014-10-231-7/+7
| | | | 16% performance improvement in layout (!)
* layout: Rewrite text and inline fragment handling during flowPatrick Walton2014-10-201-45/+93
| | | | | | | construction to avoid cloning and moving flows so much. Besides amounting to a 5%-10% win on a page with a lot of text, this simplifies and refactors the text layout code.
* Fixes the table_percentage_width_a.html reftest with incremental reflow ↵Clark Gaebel2014-10-201-9/+3
| | | | turned on.
* Use opts as a global, to avoid cloning and passing the struct all over the code.Glenn Watson2014-10-201-18/+19
|
* Fix image_dynamic_remove reftest with incremental layout turned outClark Gaebel2014-10-171-7/+13
| | | | | | | | This also adds some extra debugging infrastructure which I found useful tracking this bug down. A regression in the br reftests is also uncovered by this patch, which I'll work on fixing next. r? @pcwalton
* Fix whitespace_pre with incremental reflow turned on.Clark Gaebel2014-10-151-6/+14
| | | | | | This implements fragment merging, in order to incrementally reflow linebroken text. This makes the `whitespace_pre.html` reftest pass with incremental reflow turned on with `-i`.
* Use the Deref traits for FlowRefs.Clark Gaebel2014-10-151-18/+16
| | | | | This patch switches FlowRefs to using the Deref and DerefMut traits, instead of the custom `get` and `get_mut` functions.
* auto merge of #3640 : cgaebel/servo/incremental-flow-construction, r=pcwaltonbors-servo2014-10-141-41/+47
|\ | | | | | | | | | | This also hides the not-yet-working parts of incremental reflow behind a runtime flag. As I get the failing reftests passing, I'll send pull requests for them one by one.
| * try to reset flows which need reflow, since reflow isn't yet idempotentClark Gaebel2014-10-141-41/+47
| |
* | layout: Rewrite intrinsic inline-size and automatic table layout toPatrick Walton2014-10-141-2/+2
| | | | | | | | | | | | | | | | | | | | | | match L. David Baron's work-in-progress specification. http://dbaron.org/css/intrinsic/ Column spans are not yet supported. This effectively adds support for percentage widths, and it also fixes many bugs, improving the layout of Google and Wikipedia.
* | layout: Introduce support for legacy presentational attributes to selectorPatrick Walton2014-10-141-21/+5
| | | | | | | | | | | | | | | | matching, and use it for `<input size>` and `<td width>`. This implements a general framework for legacy presentational attributes to the DOM and style calculation, so that adding more of them later will be straightforward.
* | script: Use atom comparison in more places, especially for attributes.Patrick Walton2014-10-141-2/+2
|/ | | | 75% improvement in style recalc for Guardians of the Galaxy.
* layout: Rewrite clipping to be per-display-item instead of havingPatrick Walton2014-10-131-1/+0
| | | | | | | | | | | | | | | | | | | a separate `ClipDisplayItem`. We push down clipping areas during absolute position calculation. This makes display items into a flat list, improving cache locality. It dramatically simplifies the code all around. Because we need to push down clip rects even for absolutely-positioned children of non-absolutely-positioned flows, this patch alters the parallel traversal to compute absolute positions for absolutely-positioned children at the same time it computes absolute positions for other children. This doesn't seem to break anything either in theory (since the overall order remains correct) or in practice. It simplifies the parallel traversal code quite a bit. See the relevant Gecko bug: https://bugzilla.mozilla.org/show_bug.cgi?id=615734
* removed restyledamageClark Gaebel2014-10-091-14/+4
|
* Incremental Style RecalcClark Gaebel2014-10-091-5/+15
| | | | | | | | | | | | | | | | | | | This patch puts in the initial framework for incremental reflow. Nodes' styles are no longer recalculated unless the node has changed. I've been hacking on the general problem of incremental reflow for the past couple weeks, and I've yet to get a full implementation that actually passes all the reftests + wikipedia + cnn. Therefore, I'm going to try to land the different parts of it one by one. This patch only does incremental style recalc, without incremental flow construction, inline-size bubbling, reflow, or display lists. Those will be coming in that order as I finish them. At least with this strategy, I can land a working version of incremental reflow, even if not yet complete. r? @pcwalton
* layout: Implement `z-index`.Patrick Walton2014-10-081-1/+6
|
* layout: Implement the correct hypothetical box behavior forPatrick Walton2014-10-011-26/+71
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | absolutely-positioned elements declared with `display: inline`. Although the computed `display` property of elements with `position: absolute` is `block`, `position: absolute; display: inline` can still behave differently from `position: absolute; display: block`. This is because the hypothetical box for `position: absolute` can be at the position it would have been if it had `display: inline`. CSS 2.1 § 10.3.7 describes this case in a parenthetical: "The static-position containing block is the containing block of a hypothetical box that would have been the first box of the element if its specified 'position' value had been 'static' and its specified 'float' had been 'none'. (Note that due to the rules in section 9.7 this hypothetical calculation might require also assuming a different computed value for 'display'.)" To handle this, I had to change both style computation and layout. For the former, I added an internal property `-servo-display-for-hypothetical-box`, which stores the `display` value supplied by the author, before the computed value is calculated. Flow construction now uses this value. As for layout, implementing the proper behavior is tricky because the position of an inline fragment in the inline direction cannot be determined until height assignment, which is a parallelism hazard because in parallel layout widths are computed before heights. However, in this particular case we can avoid the parallelism hazard because the inline direction of a hypothetical box only affects the layout if an absolutely-positioned element is unconstrained in the inline direction. Therefore, we can just lay out such absolutely-positioned elements with a bogus inline position and fix it up once the true inline position of the hypothetical box is computed. The name for this fix-up process is "late computation of inline position" (and the corresponding fix-up for the block position is called "late computation of block position"). This improves the header on /r/rust.
* Remove unneeded input type information from layout.Josh Matthews2014-10-011-8/+8
|
* Disallow toggling radio buttons. Use generated content for checkboxes and ↵Josh Matthews2014-10-011-2/+2
| | | | radio buttons. Switching to the glyph 0 for the average advance width.
* Implement simple layout for text, button, radio, and checkbox inputs. ↵Josh Matthews2014-10-011-7/+26
| | | | Implement simple interaction for checkboxes and radio buttons.
* Use string-cache's Namespace typeKeegan McAllister2014-09-291-2/+1
|
* Remove the 'static lifetime parameters from TElement methodsCameron Zwarich2014-09-271-4/+4
| | | | | | This improves the static correctness of layout's use of DOM nodes. Fixes #2595.
* Merge pull request #3492 from pcwalton/clear-generated-content-tablebors-servo2014-09-261-11/+8
|\ | | | | | | | | | | layout: Support any `display` property in generated content, and allow Reviewed-by: glennw
| * layout: Support any `display` property in generated content, and allowPatrick Walton2014-09-261-11/+8
| | | | | | | | | | | | tables to clear floats. Improves the GitHub header.
* | Remove unneeded clones and add some comments.Glenn Watson2014-09-271-2/+2
| |
* | Improve acid2. Fix line height calculation. Text fragments get correct ↵Glenn Watson2014-09-261-5/+5
|/ | | | | | | | | enclosing element style. * Enabled acid2 on mac + linux. Updated the reference image. The only difference from the real acid2 now is the paint order and a 1 pixel horizontal offset on the nose. * Change line-height to be calculated correctly. * Apply enclosing element style to text fragments.
* layout: Float table wrappers directly instead of generating a blockPatrick Walton2014-09-251-14/+8
| | | | | | | | | | wrapper around them. Fixes Wikipedia tables leaking out. Along the way, I refactored tables' width calculation significantly. This was necessary in order to properly handle floated tables, as some of the logic had to be ported over from block flows.
* Eliminate warningsKeegan McAllister2014-09-201-4/+4
|
* Handle generated content with `display: block` correctly during flowPatrick Walton2014-09-191-12/+45
| | | | | | | | | | | construction. The iteration was incorrect here. Although it accidentally worked before, it will cause problems when we have incremental style recalculation. The `after_block_iteration` reftest will become interesting once we have incremental style recalc.
* layout: Remove `layout/extra.rs`.Patrick Walton2014-09-181-56/+72
| | | | Also, rename a few methods in layout that arguably had confusing names.
* Revert "script: Use atom comparison in more places, especially for ↵Josh Matthews2014-09-181-3/+1
| | | | | | attributes." for persistent test failures. This reverts commit 874db261046d6155b1942efa106d2e0014295d6d.
* Fix doctest errors in rustdoc commentsMatt Brubeck2014-09-171-0/+4
| | | | Mostly this disables doctest for comments that are not actually tests.
* script: Use atom comparison in more places, especially for attributes.Patrick Walton2014-09-171-1/+3
| | | | 75% improvement in style recalc for Guardians of the Galaxy.
* Added a bloom filter to CSS selector matching.Clark Gaebel2014-09-151-7/+6
|
* Propagate absolute descendants of inline block flows. Fixes #3326.Josh Matthews2014-09-141-3/+3
|
* Reinstate errors for unused variables and imports.Jack Moffitt2014-09-131-1/+1
|
* Address review commentsGlenn Watson2014-09-131-1/+1
|
* Add support for tables that are floated.Glenn Watson2014-09-131-4/+18
|
* Implement basic support for display: inline-block.Glenn Watson2014-09-131-12/+59
| | | | | | | This still needs a lot of work, but it covers the basic cases and improves wikipedia while passing all existing tests. Tweak reftest to deal with linux/travis black background.
* layout: Don't crash on floated generated content.Patrick Walton2014-09-121-1/+3
| | | | | | | | | It doesn't construct the float correctly, but at least it doesn't crash anymore. Fixes Reddit. Closes #3287.
* Cargoify servoJack Moffitt2014-09-081-0/+1049
generated by cgit v1.2.3 (git 2.25.1) at 2025-04-28 11:51:29 +0000