aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Update webrender (new gpu profiler support).Glenn Watson2016-10-072-4/+4
|
* Auto merge of #13623 - larsbergstrom:update_glutin, r=glennwbors-servo2016-10-062-8/+8
|\ | | | | | | | | | | | | | | | | | | | | Update glutin to pick up Windows CreateWindowExW fix r? @glennw or @emilio or whomever <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13623) <!-- Reviewable:end -->
| * Update glutin to pick up Windows CreateWindowExW fixLars Bergstrom2016-10-062-8/+8
| |
* | Auto merge of #13621 - larsbergstrom:add_msvc_instructions, r=metajackbors-servo2016-10-061-2/+29
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Instructions for building with the MSVC toolchain <!-- Please describe your changes on the following line: --> Adding instructions to build using the MSVC toolchain. r? @vvuk --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x ] `./mach build -d` does not report any errors - [x ] `./mach test-tidy` does not report any errors - [x ] These changes fix #13206 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13621) <!-- Reviewable:end -->
| * | Instructions for building with the MSVC toolchainLars Bergstrom2016-10-061-2/+29
| | |
* | | Auto merge of #13611 - aneeshusa:migrate-steps-from-saltfs, r=Ms2gerbors-servo2016-10-061-5/+23
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Sync Buildbot steps config from saltfs <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [x] These changes are part of https://github.com/servo/saltfs/issues/316 <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because they just copy the steps configuration <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Now that our Buildbot configuration is successfully able to read the steps configuration from the main servo repo and run builds, sync the steps in the servo tree to match the latest steps.yml from the saltfs repo. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13611) <!-- Reviewable:end -->
| * | | Sync Buildbot steps config from saltfsAneesh Agrawal2016-10-061-5/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Now that our Buildbot configuration is successfully able to read the steps configuration from the main servo repo and run builds, sync the steps in the servo tree to match the latest steps.yml from the saltfs repo.
* | | | Auto merge of #13610 - glennw:sim-mouse-wr, r=mbrubeckbors-servo2016-10-061-11/+14
|\ \ \ \ | |_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Allow simulate_mouse_click to work with webrender. Instead of dispatching to a specific layer, call the dispatch functions for mouse (move) events that handle whether webrender is enabled or not. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13610) <!-- Reviewable:end -->
| * | | Allow simulate_mouse_click to work with webrender.Glenn Watson2016-10-061-11/+14
| | | | | | | | | | | | | | | | | | | | | | | | Instead of dispatching to a specific layer, call the dispatch functions for mouse (move) events that handle whether webrender is enabled or not.
* | | | Auto merge of #13224 - nox:union, r=jdmbors-servo2016-10-062-15/+23
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make TopTypeId an untagged union <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13224) <!-- Reviewable:end -->
| * | | | Make TopTypeId an untagged unionAnthony Ramine2016-10-062-14/+22
| | | | |
| * | | | Reorder features in script crateAnthony Ramine2016-10-061-1/+1
| |/ / /
* | | | Auto merge of #13597 - servo:fetch, r=jdmbors-servo2016-10-06105-283/+160
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Provide the fetched data to fetch() consumers. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13597) <!-- Reviewable:end -->
| * | | | Enable some referrer-policy tests now that they no longer time out.Ms2ger2016-10-0696-224/+58
| | | | |
| * | | | Provide the fetched data to fetch() consumers.Ms2ger2016-10-069-59/+102
| | |/ / | |/| |
* | | | Auto merge of #13616 - servo:PropertyDeclarationBlock_independence_day, r=Ms2gerbors-servo2016-10-063-377/+394
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Move PropertyDeclarationBlock into its own module. <!-- Please describe your changes on the following line: --> `properties.mako.rs` (its previous location) is a fairly big file. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require new tests because refactor <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13616) <!-- Reviewable:end -->
| * | | | Move PropertyDeclarationBlock into its own module.Simon Sapin2016-10-063-377/+394
| |/ / /
* | | | Auto merge of #13615 - servo:jdm-patch-1, r=Ms2gerbors-servo2016-10-061-1/+1
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | Disabling multicol tests due to #13613 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13615) <!-- Reviewable:end -->
| * | | Disabling multicol tests due to #13613Josh Matthews2016-10-061-1/+1
|/ / /
* | | Auto merge of #13599 - slester:master, r=jdmbors-servo2016-10-05156-0/+475
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Run CSS Multicolumn tests automatically <!-- Please describe your changes on the following line: --> Implements the CSS multicolumn tests as outlined in issue #13587. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #13587 <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because they implement tests for other features. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13599) <!-- Reviewable:end -->
| * | Run CSS Multicolumn tests automaticallyStephen Lester2016-10-05156-0/+475
| | |
* | | Auto merge of #13580 - ↵bors-servo2016-10-052-62/+20
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | asajeffrey:script-browsingcontext-without-session-history, r=ConnorGBrewster. Removed the session history from BrowsingContext. <!-- Please describe your changes on the following line: --> The session history is stored in the constellation and accessed via the `History` object, so `BrowsingContext` doesn't need to track it. cc @jdm @ConnorGBrewster @Ms2ger --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because it's a refactoring. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13580) <!-- Reviewable:end -->
| * | | Removed the session history from BrowsingContext.Alan Jeffrey2016-10-052-62/+20
| | | |
* | | | Auto merge of #13600 - slester:13586, r=jdmbors-servo2016-10-051-26/+30
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Invert conditional and return early for AddEventListener/RemoveEventL… <!-- Please describe your changes on the following line: --> Cleans up code as described in #13586 by returning early instead of nesting everything in an `if` statement. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #13586 <!-- Either: --> - [x] These changes do not require tests because the change is a cleanup of code and the author of the issue stated that new tests were not required. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> …istener <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13600) <!-- Reviewable:end -->
| * | | | Invert conditional and return early for AddEventListener/RemoveEventListenerStephen Lester2016-10-051-26/+30
| | |/ / | |/| |
* | | | Auto merge of #13601 - larsbergstrom:debug_assertions_cef, r=noxbors-servo2016-10-051-1/+10
|\ \ \ \ | |/ / / |/| | / | | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Ensure that SERVO_ENABLE_DEBUG_ASSERTIONS is also used in build-cef r? @nox Fixes #13591 This fixes the problem with rebuilding all of CEF on the linux-rel builders by ensuring it gets the same `RUSTFLAGS`. Proof: ``` [larsberg@larsberg servo2]$ ./mach build-cef -r Compiling embedding v0.0.1 (file:///Users/larsberg/servo2/ports/cef) Finished release [optimized] target(s) in 35.42 secs [Warning] Could not generate notification! Optional Python module 'pyobjc' is not installed. CEF build completed in 0:00:38 [larsberg@larsberg servo2]$ ``` <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13601) <!-- Reviewable:end -->
| * | Ensure that SERVO_ENABLE_DEBUG_ASSERTIONS is also used in build-cefLars Bergstrom2016-10-051-1/+10
| | |
* | | Auto merge of #13592 - glennw:update-wr-text-runs, r=pcwaltonbors-servo2016-10-053-4/+9
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update webrender (text run + transforms fix). <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13592) <!-- Reviewable:end -->
| * | | Update webrender (text run + transforms fix).Glenn Watson2016-10-053-4/+9
| | | |
* | | | Auto merge of #13585 - shubheksha:fix/13581, r=jdmbors-servo2016-10-052-2/+0
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Removed duplicate #![feature(plugin)] <!-- Please describe your changes on the following line: --> Removed duplicate ` #![feature(plugin)]` from two files. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #13581 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because it's removing a few lines. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13585) <!-- Reviewable:end -->
| * | | | Removed duplicate #![feature(plugin)]Shubheksha Jalan2016-10-052-2/+0
| | | | |
* | | | | Auto merge of #13577 - servo:warnings, r=jdmbors-servo2016-10-052-4/+2
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Squash some build warnings. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13577) <!-- Reviewable:end -->
| * | | | | Squash some build warnings.Ms2ger2016-10-042-4/+2
| | | | | |
* | | | | | Auto merge of #13569 - Manishearth:simpliffi, r=emiliobors-servo2016-10-056-171/+41
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Start simplifying FFI ownership sugar This is step one of a series of changes planned to make the ownership sugar easier to use. This was blocked on #13038 *very* unsure about second commit. Don't like the thought of accepting types with destructors over FFI. Probably will revert it. Leaving it in for now in case you have some insight. Eventually at least for the borrowed stuff I want to use T directly (because the crates are merged now), instead of the fake void types. Perhaps for the others too. I might include those changes in this PR -- was originally planning to but I realized that these steps could be split out. Tentative plan for `Owned` (assuming it's not removed) is to have `Owned<T> <-> Box<T>` (same `T`, no "FFI type") conversions. We will only use ownership wrapper types for things with destructors, and try to keep the conversion simple. I'm envisioning a couple methods for arc/strong and a few more for box/owned. We may need to introduce new wrapper types for gecko-side managed objects (`RefPtr<T>`, `UniquePtr<T>`) but that should be all the wrapper types we have in the ownership sugar. This PR relies on the guarantee that `Option<&T>` and `Option<Box<T>>` are pointer-sized via the `NonZero` optimization. I am now less unconvinced that this is a good idea :wink:. r? @emilio cc @mystor <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13569) <!-- Reviewable:end -->
| * | | | | | Remove Borrowed<T>/BorrowedMut<T>, use Option<&T> instead.Manish Goregaokar2016-10-046-171/+41
| | | | | | |
* | | | | | | Auto merge of #13556 - Manishearth:serialize-one, r=emiliobors-servo2016-10-041-0/+46
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add to_css_single_value for serializing a single PropertyDeclarationBlock (fixes #13423) r? @birtles This needs to take the name of the property in question as input so that it can figure out which shorthand to serialize to (if any), since some props are part of multiple shorthands (and you need a way to distinguish between the lone value and the shorthand). I can tweak this to accept an `Option<Shorthand>` in case you only want to pass in the property name for shorthands. In case you don't want to handle shorthands at all, we probably don't need this method at all, since you can just assert that there's a single field and serialize that. Also, is `!important` involved here? <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13556) <!-- Reviewable:end -->
| * | | | | | | Add to_css_single_value for serializing a single PropertyDeclarationBlock ↵Manish Goregaokar2016-10-041-0/+46
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (fixes #13423)
* | | | | | | | Auto merge of #13579 - servo:old-doc, r=Wafflespeanutbors-servo2016-10-041-3/+0
|\ \ \ \ \ \ \ \ | |_|_|_|_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove some documentation that is no longer correct. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13579) <!-- Reviewable:end -->
| * | | | | | | Remove some documentation that is no longer correct.Ms2ger2016-10-041-3/+0
| | | | | | | |
* | | | | | | | Auto merge of #13490 - pcwalton:inline-absolute-hypothetical-metrics, ↵bors-servo2016-10-0438-156/+231
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | r=notriddle layout: Place inline absolute hypothetical boxes properly during block fragment position assignment. r? @notriddle Closes #13471. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13490) <!-- Reviewable:end -->
| * | | | | | | | layout: Place inline absolute hypothetical boxes properly during blockPatrick Walton2016-10-0438-156/+231
| | |_|_|_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fragment position assignment. Improves Rust documentation. Closes #13471.
* | | | | | | | Auto merge of #13567 - glennw:win-fonts, r=larsbergstrombors-servo2016-10-047-13/+195
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Minimal Win32 font platform implementation. This uses a (very simple) Win32 API call to enumerate font families available, and load them as byte buffers. The font rasterization itself is done by freetype. This gets Servo + WR + Windows working, but should be improved by adding a proper implementation that matches fonts correctly and also uses DirectWrite (or GDI) to handle font rasterization. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13567) <!-- Reviewable:end -->
| * | | | | | | | Minimal Win32 font platform implementation.Glenn Watson2016-10-057-13/+195
| |/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This uses a (very simple) Win32 API call to enumerate font families available, and load them as byte buffers. The font rasterization itself is done by freetype. This gets Servo + WR + Windows working, but should be improved by adding a proper implementation that matches fonts correctly and also uses DirectWrite (or GDI) to handle font rasterization.
* | | | | | | | Auto merge of #13575 - servo:fetch-link, r=jdmbors-servo2016-10-041-13/+34
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use the fetch stack for stylesheets. Fixes #13462. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13575) <!-- Reviewable:end -->
| * | | | | | | | Use the fetch stack for stylesheets.Ms2ger2016-10-041-13/+34
| | |_|_|_|/ / / | |/| | | | | | | | | | | | | | | | | | | | | | Fixes #13462.
* | | | | | | | Auto merge of #13572 - nox:cleanup-global, r=jdmbors-servo2016-10-045-19/+8
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Clean up some global things <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13572) <!-- Reviewable:end -->
| * | | | | | | | Remove ScopeThings::pipeline_idAnthony Ramine2016-10-043-4/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It can be retrieved through its init field.
| * | | | | | | | Simplify GlobalRef::resource_threadsAnthony Ramine2016-10-041-6/+1
| | | | | | | | |
| * | | | | | | | Remove GlobalRef::get_worker_idAnthony Ramine2016-10-042-9/+6
| | | | | | | | |
* | | | | | | | | Auto merge of #13472 - asajeffrey:util-remutex-dont-log-while-mutating-lock, ↵bors-servo2016-10-042-9/+27
|\ \ \ \ \ \ \ \ \ | |_|_|/ / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | r=jdm Don't log in the middle of mutating a reentrant lock <!-- Please describe your changes on the following line: --> Moved assertion that we are the lock owner to after the lock release. The problem is that Servo uses a reentrant lock for logging, so logging in the middle of mutating the lock is A Bad Idea. While I was at it, I tidied up the reentrant lock code. cc @jdm --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #13463. - [X] These changes do not require tests because they fix an existing intermittent. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13472) <!-- Reviewable:end -->
generated by cgit v1.2.3 (git 2.25.1) at 2025-06-01 23:30:43 +0000