diff options
Diffstat (limited to 'components/script')
-rw-r--r-- | components/script/dom/bindings/trace.rs | 3 | ||||
-rw-r--r-- | components/script/dom/bluetooth.rs | 4 | ||||
-rw-r--r-- | components/script/dom/eventsource.rs | 486 | ||||
-rw-r--r-- | components/script/dom/globalscope.rs | 5 | ||||
-rw-r--r-- | components/script/dom/htmlimageelement.rs | 8 | ||||
-rw-r--r-- | components/script/dom/htmllinkelement.rs | 4 | ||||
-rw-r--r-- | components/script/dom/htmlmediaelement.rs | 5 | ||||
-rw-r--r-- | components/script/dom/htmlscriptelement.rs | 4 | ||||
-rw-r--r-- | components/script/dom/webidls/EventSource.webidl | 3 | ||||
-rw-r--r-- | components/script/dom/websocket.rs | 38 | ||||
-rw-r--r-- | components/script/dom/window.rs | 2 | ||||
-rw-r--r-- | components/script/dom/workerglobalscope.rs | 5 | ||||
-rw-r--r-- | components/script/dom/xmlhttprequest.rs | 23 | ||||
-rw-r--r-- | components/script/fetch.rs | 9 | ||||
-rw-r--r-- | components/script/lib.rs | 1 | ||||
-rw-r--r-- | components/script/network_listener.rs | 10 | ||||
-rw-r--r-- | components/script/script_thread.rs | 7 | ||||
-rw-r--r-- | components/script/task_source/networking.rs | 31 | ||||
-rw-r--r-- | components/script/timers.rs | 3 |
19 files changed, 560 insertions, 91 deletions
diff --git a/components/script/dom/bindings/trace.rs b/components/script/dom/bindings/trace.rs index b8274aec90c..8f5aaba2eca 100644 --- a/components/script/dom/bindings/trace.rs +++ b/components/script/dom/bindings/trace.rs @@ -63,7 +63,7 @@ use net_traits::{Metadata, NetworkError, ReferrerPolicy, ResourceThreads}; use net_traits::filemanager_thread::RelativePos; use net_traits::image::base::{Image, ImageMetadata}; use net_traits::image_cache_thread::{ImageCacheChan, ImageCacheThread}; -use net_traits::request::Request; +use net_traits::request::{Request, RequestInit}; use net_traits::response::{Response, ResponseBody}; use net_traits::response::HttpsState; use net_traits::storage_thread::StorageType; @@ -349,6 +349,7 @@ no_jsmanaged_fields!(AttrValue); no_jsmanaged_fields!(Snapshot); no_jsmanaged_fields!(HttpsState); no_jsmanaged_fields!(Request); +no_jsmanaged_fields!(RequestInit); no_jsmanaged_fields!(SharedRt); no_jsmanaged_fields!(TouchpadPressurePhase); no_jsmanaged_fields!(USVString); diff --git a/components/script/dom/bluetooth.rs b/components/script/dom/bluetooth.rs index 1f5fd15c49f..0a6634f35dc 100644 --- a/components/script/dom/bluetooth.rs +++ b/components/script/dom/bluetooth.rs @@ -148,14 +148,14 @@ pub fn response_async<T: AsyncBluetoothListener + Reflectable + 'static>( promise: &Rc<Promise>, receiver: &T) -> IpcSender<BluetoothResponseResult> { let (action_sender, action_receiver) = ipc::channel().unwrap(); - let chan = receiver.global().networking_task_source(); + let task_source = receiver.global().networking_task_source(); let context = Arc::new(Mutex::new(BluetoothContext { promise: Some(TrustedPromise::new(promise.clone())), receiver: Trusted::new(receiver), })); let listener = NetworkListener { context: context, - script_chan: chan, + task_source: task_source, wrapper: None, }; ROUTER.add_route(action_receiver.to_opaque(), box move |message| { diff --git a/components/script/dom/eventsource.rs b/components/script/dom/eventsource.rs index f05e73beafa..2eabfcbc8b0 100644 --- a/components/script/dom/eventsource.rs +++ b/components/script/dom/eventsource.rs @@ -6,18 +6,50 @@ use dom::bindings::cell::DOMRefCell; use dom::bindings::codegen::Bindings::EventHandlerBinding::EventHandlerNonNull; use dom::bindings::codegen::Bindings::EventSourceBinding::{EventSourceInit, EventSourceMethods, Wrap}; use dom::bindings::error::{Error, Fallible}; +use dom::bindings::inheritance::Castable; use dom::bindings::js::Root; -use dom::bindings::reflector::reflect_dom_object; +use dom::bindings::refcounted::Trusted; +use dom::bindings::reflector::{Reflectable, reflect_dom_object}; use dom::bindings::str::DOMString; +use dom::event::Event; use dom::eventtarget::EventTarget; use dom::globalscope::GlobalScope; +use dom::messageevent::MessageEvent; +use encoding::Encoding; +use encoding::all::UTF_8; +use euclid::length::Length; +use hyper::header::{Accept, qitem}; +use ipc_channel::ipc; +use ipc_channel::router::ROUTER; +use js::conversions::ToJSValConvertible; +use js::jsapi::JSAutoCompartment; +use js::jsval::UndefinedValue; +use mime::{Mime, TopLevel, SubLevel}; +use net_traits::{CoreResourceMsg, FetchMetadata, FetchResponseMsg, FetchResponseListener, NetworkError}; +use net_traits::request::{CacheMode, CorsSettings, CredentialsMode}; +use net_traits::request::{RequestInit, RequestMode}; +use network_listener::{NetworkListener, PreInvoke}; +use script_thread::Runnable; +use servo_atoms::Atom; use std::cell::Cell; +use std::mem; +use std::str::{Chars, FromStr}; +use std::sync::{Arc, Mutex}; +use task_source::TaskSource; +use timers::OneshotTimerCallback; use url::Url; +header! { (LastEventId, "Last-Event-ID") => [String] } + +const DEFAULT_RECONNECTION_TIME: u64 = 5000; + +#[derive(JSTraceable, PartialEq, Copy, Clone, Debug, HeapSizeOf)] +struct GenerationId(u32); + #[derive(JSTraceable, PartialEq, Copy, Clone, Debug, HeapSizeOf)] -enum EventSourceReadyState { +/// https://html.spec.whatwg.org/multipage/#dom-eventsource-readystate +enum ReadyState { Connecting = 0, - #[allow(dead_code)] Open = 1, Closed = 2 } @@ -26,9 +58,254 @@ enum EventSourceReadyState { pub struct EventSource { eventtarget: EventTarget, url: Url, - ready_state: Cell<EventSourceReadyState>, + request: DOMRefCell<Option<RequestInit>>, + last_event_id: DOMRefCell<DOMString>, + reconnection_time: Cell<u64>, + generation_id: Cell<GenerationId>, + + ready_state: Cell<ReadyState>, with_credentials: bool, - last_event_id: DOMRefCell<DOMString> +} + +enum ParserState { + Field, + Comment, + Value, + Eol +} + +struct EventSourceContext { + event_source: Trusted<EventSource>, + gen_id: GenerationId, + action_sender: ipc::IpcSender<FetchResponseMsg>, + + parser_state: ParserState, + field: String, + value: String, + origin: String, + + event_type: String, + data: String, + last_event_id: String, +} + +impl EventSourceContext { + fn announce_the_connection(&self) { + let event_source = self.event_source.root(); + if self.gen_id != event_source.generation_id.get() { + return; + } + let runnable = box AnnounceConnectionRunnable { + event_source: self.event_source.clone() + }; + let _ = event_source.global().networking_task_source().queue(runnable, &*event_source.global()); + } + + fn fail_the_connection(&self) { + let event_source = self.event_source.root(); + if self.gen_id != event_source.generation_id.get() { + return; + } + let runnable = box FailConnectionRunnable { + event_source: self.event_source.clone() + }; + let _ = event_source.global().networking_task_source().queue(runnable, &*event_source.global()); + } + + // https://html.spec.whatwg.org/multipage/#reestablish-the-connection + fn reestablish_the_connection(&self) { + let event_source = self.event_source.root(); + + if self.gen_id != event_source.generation_id.get() { + return; + } + + // Step 1 + let runnable = box ReestablishConnectionRunnable { + event_source: self.event_source.clone(), + action_sender: self.action_sender.clone() + }; + let _ = event_source.global().networking_task_source().queue(runnable, &*event_source.global()); + } + + // https://html.spec.whatwg.org/multipage/#processField + fn process_field(&mut self) { + match &*self.field { + "event" => mem::swap(&mut self.event_type, &mut self.value), + "data" => { + self.data.push_str(&self.value); + self.data.push('\n'); + } + "id" => mem::swap(&mut self.last_event_id, &mut self.value), + "retry" => if let Ok(time) = u64::from_str(&self.value) { + self.event_source.root().reconnection_time.set(time); + }, + _ => () + } + + self.field.clear(); + self.value.clear(); + } + + // https://html.spec.whatwg.org/multipage/#dispatchMessage + #[allow(unsafe_code)] + fn dispatch_event(&mut self) { + let event_source = self.event_source.root(); + // Step 1 + *event_source.last_event_id.borrow_mut() = DOMString::from(self.last_event_id.clone()); + // Step 2 + if self.data.is_empty() { + self.data.clear(); + self.event_type.clear(); + return; + } + // Step 3 + if let Some(last) = self.data.pop() { + if last != '\n' { + self.data.push(last); + } + } + // Step 6 + let type_ = if !self.event_type.is_empty() { + Atom::from(self.event_type.clone()) + } else { + atom!("message") + }; + // Steps 4-5 + let event = { + let _ac = JSAutoCompartment::new(event_source.global().get_cx(), + event_source.reflector().get_jsobject().get()); + rooted!(in(event_source.global().get_cx()) let mut data = UndefinedValue()); + unsafe { self.data.to_jsval(event_source.global().get_cx(), data.handle_mut()) }; + MessageEvent::new(&*event_source.global(), type_, false, false, data.handle(), + DOMString::from(self.origin.clone()), + event_source.last_event_id.borrow().clone()) + }; + // Step 7 + self.event_type.clear(); + self.data.clear(); + // Step 8 + let runnable = box DispatchEventRunnable { + event_source: self.event_source.clone(), + event: Trusted::new(&event) + }; + let _ = event_source.global().networking_task_source().queue(runnable, &*event_source.global()); + } + + // https://html.spec.whatwg.org/multipage/#event-stream-interpretation + fn parse(&mut self, stream: Chars) { + let mut stream = stream.peekable(); + + while let Some(ch) = stream.next() { + match (ch, &self.parser_state) { + (':', &ParserState::Eol) => self.parser_state = ParserState::Comment, + (':', &ParserState::Field) => { + self.parser_state = ParserState::Value; + if let Some(&' ') = stream.peek() { + stream.next(); + } + } + + ('\n', &ParserState::Value) => { + self.parser_state = ParserState::Eol; + self.process_field(); + } + ('\r', &ParserState::Value) => { + if let Some(&'\n') = stream.peek() { + continue; + } + self.parser_state = ParserState::Eol; + self.process_field(); + } + + ('\n', &ParserState::Field) => { + self.parser_state = ParserState::Eol; + self.process_field(); + } + ('\r', &ParserState::Field) => { + if let Some(&'\n') = stream.peek() { + continue; + } + self.parser_state = ParserState::Eol; + self.process_field(); + } + + ('\n', &ParserState::Eol) => self.dispatch_event(), + ('\r', &ParserState::Eol) => { + if let Some(&'\n') = stream.peek() { + continue; + } + self.dispatch_event(); + } + + ('\n', &ParserState::Comment) => self.parser_state = ParserState::Eol, + ('\r', &ParserState::Comment) => { + if let Some(&'\n') = stream.peek() { + continue; + } + self.parser_state = ParserState::Eol; + } + + (_, &ParserState::Field) => self.field.push(ch), + (_, &ParserState::Value) => self.value.push(ch), + (_, &ParserState::Eol) => { + self.parser_state = ParserState::Field; + self.field.push(ch); + } + (_, &ParserState::Comment) => (), + } + } + } +} + +impl FetchResponseListener for EventSourceContext { + fn process_request_body(&mut self) { + // TODO + } + + fn process_request_eof(&mut self) { + // TODO + } + + fn process_response(&mut self, metadata: Result<FetchMetadata, NetworkError>) { + match metadata { + Ok(fm) => { + let meta = match fm { + FetchMetadata::Unfiltered(m) => m, + FetchMetadata::Filtered { unsafe_, .. } => unsafe_ + }; + match meta.content_type { + None => self.fail_the_connection(), + Some(ct) => match ct.into_inner().0 { + Mime(TopLevel::Text, SubLevel::EventStream, _) => { + self.origin = meta.final_url.origin().unicode_serialization(); + self.announce_the_connection(); + } + _ => self.fail_the_connection() + } + } + } + Err(_) => { + self.reestablish_the_connection(); + } + } + } + + fn process_response_chunk(&mut self, chunk: Vec<u8>) { + let mut stream = String::new(); + UTF_8.raw_decoder().raw_feed(&chunk, &mut stream); + self.parse(stream.chars()) + } + + fn process_response_eof(&mut self, _response: Result<(), NetworkError>) { + self.reestablish_the_connection(); + } +} + +impl PreInvoke for EventSourceContext { + fn should_invoke(&self) -> bool { + self.event_source.root().generation_id.get() == self.gen_id + } } impl EventSource { @@ -36,9 +313,13 @@ impl EventSource { EventSource { eventtarget: EventTarget::new_inherited(), url: url, - ready_state: Cell::new(EventSourceReadyState::Connecting), + request: DOMRefCell::new(None), + last_event_id: DOMRefCell::new(DOMString::from("")), + reconnection_time: Cell::new(DEFAULT_RECONNECTION_TIME), + generation_id: Cell::new(GenerationId(0)), + + ready_state: Cell::new(ReadyState::Connecting), with_credentials: with_credentials, - last_event_id: DOMRefCell::new(DOMString::from("")) } } @@ -48,27 +329,78 @@ impl EventSource { Wrap) } + pub fn request(&self) -> RequestInit { + self.request.borrow().clone().unwrap() + } + pub fn Constructor(global: &GlobalScope, - url_str: DOMString, + url: DOMString, event_source_init: &EventSourceInit) -> Fallible<Root<EventSource>> { - // Steps 1-2 - let base_url = global.get_url(); - let url = match base_url.join(&*url_str) { + // TODO: Step 2 relevant settings object + // Step 3 + let base_url = global.api_base_url(); + let url_record = match base_url.join(&*url) { Ok(u) => u, + // Step 4 Err(_) => return Err(Error::Syntax) }; - // Step 3 - let event_source = EventSource::new(global, url, event_source_init.withCredentials); - // Step 4 - // Step 5 - // Step 6 - // Step 7 + // Step 1, 5 + let ev = EventSource::new(global, url_record.clone(), event_source_init.withCredentials); + // Steps 6-7 + let cors_attribute_state = if event_source_init.withCredentials { + CorsSettings::UseCredentials + } else { + CorsSettings::Anonymous + }; // Step 8 - // Step 9 + // TODO: Step 9 set request's client settings + let mut request = RequestInit { + url: url_record, + origin: global.get_url(), + pipeline_id: Some(global.pipeline_id()), + // https://html.spec.whatwg.org/multipage/#create-a-potential-cors-request + use_url_credentials: true, + mode: RequestMode::CorsMode, + credentials_mode: if cors_attribute_state == CorsSettings::Anonymous { + CredentialsMode::CredentialsSameOrigin + } else { + CredentialsMode::Include + }, + ..RequestInit::default() + }; // Step 10 + request.headers.set(Accept(vec![qitem(mime!(Text / EventStream))])); // Step 11 - Ok(event_source) + request.cache_mode = CacheMode::NoStore; // Step 12 + *ev.request.borrow_mut() = Some(request.clone()); + // Step 14 + let (action_sender, action_receiver) = ipc::channel().unwrap(); + let context = EventSourceContext { + event_source: Trusted::new(&ev), + gen_id: ev.generation_id.get(), + action_sender: action_sender.clone(), + + parser_state: ParserState::Eol, + field: String::new(), + value: String::new(), + origin: String::new(), + + event_type: String::new(), + data: String::new(), + last_event_id: String::new(), + }; + let listener = NetworkListener { + context: Arc::new(Mutex::new(context)), + task_source: global.networking_task_source(), + wrapper: Some(global.get_runnable_wrapper()) + }; + ROUTER.add_route(action_receiver.to_opaque(), box move |message| { + listener.notify_fetch(message.to().unwrap()); + }); + global.core_resource_thread().send(CoreResourceMsg::Fetch(request, action_sender)).unwrap(); + // Step 13 + Ok(ev) } } @@ -99,7 +431,119 @@ impl EventSourceMethods for EventSource { // https://html.spec.whatwg.org/multipage/#dom-eventsource-close fn Close(&self) { - self.ready_state.set(EventSourceReadyState::Closed); - // TODO: Terminate ongoing fetch + let GenerationId(prev_id) = self.generation_id.get(); + self.generation_id.set(GenerationId(prev_id + 1)); + self.ready_state.set(ReadyState::Closed); + } +} + +pub struct AnnounceConnectionRunnable { + event_source: Trusted<EventSource>, +} + +impl Runnable for AnnounceConnectionRunnable { + fn name(&self) -> &'static str { "EventSource AnnounceConnectionRunnable" } + + // https://html.spec.whatwg.org/multipage/#announce-the-connection + fn handler(self: Box<AnnounceConnectionRunnable>) { + let event_source = self.event_source.root(); + if event_source.ready_state.get() != ReadyState::Closed { + event_source.ready_state.set(ReadyState::Open); + event_source.upcast::<EventTarget>().fire_event(atom!("open")); + } + } +} + +pub struct FailConnectionRunnable { + event_source: Trusted<EventSource>, +} + +impl Runnable for FailConnectionRunnable { + fn name(&self) -> &'static str { "EventSource FailConnectionRunnable" } + + // https://html.spec.whatwg.org/multipage/#fail-the-connection + fn handler(self: Box<FailConnectionRunnable>) { + let event_source = self.event_source.root(); + if event_source.ready_state.get() != ReadyState::Closed { + event_source.ready_state.set(ReadyState::Closed); + event_source.upcast::<EventTarget>().fire_event(atom!("error")); + } + } +} + +pub struct ReestablishConnectionRunnable { + event_source: Trusted<EventSource>, + action_sender: ipc::IpcSender<FetchResponseMsg>, +} + +impl Runnable for ReestablishConnectionRunnable { + fn name(&self) -> &'static str { "EventSource ReestablishConnectionRunnable" } + + // https://html.spec.whatwg.org/multipage/#reestablish-the-connection + fn handler(self: Box<ReestablishConnectionRunnable>) { + let event_source = self.event_source.root(); + // Step 1.1 + if event_source.ready_state.get() == ReadyState::Closed { + return; + } + // Step 1.2 + event_source.ready_state.set(ReadyState::Connecting); + // Step 1.3 + event_source.upcast::<EventTarget>().fire_event(atom!("error")); + // Step 2 + let duration = Length::new(event_source.reconnection_time.get()); + // TODO Step 3: Optionally wait some more + // Steps 4-5 + let callback = OneshotTimerCallback::EventSourceTimeout(EventSourceTimeoutCallback { + event_source: self.event_source.clone(), + action_sender: self.action_sender.clone() + }); + let _ = event_source.global().schedule_callback(callback, duration); + } +} + +#[derive(JSTraceable, HeapSizeOf)] +pub struct EventSourceTimeoutCallback { + #[ignore_heap_size_of = "Because it is non-owning"] + event_source: Trusted<EventSource>, + #[ignore_heap_size_of = "Because it is non-owning"] + action_sender: ipc::IpcSender<FetchResponseMsg>, +} + +impl EventSourceTimeoutCallback { + // https://html.spec.whatwg.org/multipage/#reestablish-the-connection + pub fn invoke(self) { + let event_source = self.event_source.root(); + let global = event_source.global(); + // Step 5.1 + if event_source.ready_state.get() != ReadyState::Connecting { + return; + } + // Step 5.2 + let mut request = event_source.request(); + // Step 5.3 + if !event_source.last_event_id.borrow().is_empty() { + request.headers.set(LastEventId(String::from(event_source.last_event_id.borrow().clone()))); + } + // Step 5.4 + global.core_resource_thread().send(CoreResourceMsg::Fetch(request, self.action_sender)).unwrap(); + } +} + +pub struct DispatchEventRunnable { + event_source: Trusted<EventSource>, + event: Trusted<MessageEvent>, +} + +impl Runnable for DispatchEventRunnable { + fn name(&self) -> &'static str { "EventSource DispatchEventRunnable" } + + // https://html.spec.whatwg.org/multipage/#dispatchMessage + fn handler(self: Box<DispatchEventRunnable>) { + let event_source = self.event_source.root(); + // Step 8 + if event_source.ready_state.get() != ReadyState::Closed { + self.event.root().upcast::<Event>().fire(&event_source.upcast()); + } } } diff --git a/components/script/dom/globalscope.rs b/components/script/dom/globalscope.rs index fc160675df5..2338dcf32e7 100644 --- a/components/script/dom/globalscope.rs +++ b/components/script/dom/globalscope.rs @@ -42,6 +42,7 @@ use std::collections::hash_map::Entry; use std::ffi::CString; use std::panic; use task_source::file_reading::FileReadingTaskSource; +use task_source::networking::NetworkingTaskSource; use time::{Timespec, get_time}; use timers::{IsInterval, OneshotTimerCallback, OneshotTimerHandle}; use timers::{OneshotTimers, TimerCallback}; @@ -325,12 +326,12 @@ impl GlobalScope { /// `ScriptChan` to send messages to the networking task source of /// this of this global scope. - pub fn networking_task_source(&self) -> Box<ScriptChan + Send> { + pub fn networking_task_source(&self) -> NetworkingTaskSource { if let Some(window) = self.downcast::<Window>() { return window.networking_task_source(); } if let Some(worker) = self.downcast::<WorkerGlobalScope>() { - return worker.script_chan(); + return worker.networking_task_source(); } unreachable!(); } diff --git a/components/script/dom/htmlimageelement.rs b/components/script/dom/htmlimageelement.rs index e8a269c782c..d8ecda30943 100644 --- a/components/script/dom/htmlimageelement.rs +++ b/components/script/dom/htmlimageelement.rs @@ -26,8 +26,6 @@ use ipc_channel::ipc; use ipc_channel::router::ROUTER; use net_traits::image::base::{Image, ImageMetadata}; use net_traits::image_cache_thread::{ImageResponder, ImageResponse}; -use script_runtime::CommonScriptMsg; -use script_runtime::ScriptThreadEventCategory::UpdateReplacedElement; use script_thread::Runnable; use std::i32; use std::sync::Arc; @@ -140,7 +138,7 @@ impl HTMLImageElement { let trusted_node = Trusted::new(self); let (responder_sender, responder_receiver) = ipc::channel().unwrap(); - let script_chan = window.networking_task_source(); + let task_source = window.networking_task_source(); let wrapper = window.get_runnable_wrapper(); ROUTER.add_route(responder_receiver.to_opaque(), box move |message| { // Return the image via a message to the script thread, which marks the element @@ -148,9 +146,7 @@ impl HTMLImageElement { let image_response = message.to().unwrap(); let runnable = box ImageResponseHandlerRunnable::new( trusted_node.clone(), image_response); - let runnable = wrapper.wrap_runnable(runnable); - let _ = script_chan.send(CommonScriptMsg::RunnableMsg( - UpdateReplacedElement, runnable)); + let _ = task_source.queue_with_wrapper(runnable, &wrapper); }); image_cache.request_image_and_metadata(img_url, diff --git a/components/script/dom/htmllinkelement.rs b/components/script/dom/htmllinkelement.rs index 90499388153..5df64f62ca0 100644 --- a/components/script/dom/htmllinkelement.rs +++ b/components/script/dom/htmllinkelement.rs @@ -243,8 +243,8 @@ impl HTMLLinkElement { let (action_sender, action_receiver) = ipc::channel().unwrap(); let listener = NetworkListener { context: context, - script_chan: document.window().networking_task_source(), - wrapper: Some(document.window().get_runnable_wrapper()), + task_source: document.window().networking_task_source(), + wrapper: Some(document.window().get_runnable_wrapper()) }; ROUTER.add_route(action_receiver.to_opaque(), box move |message| { listener.notify_fetch(message.to().unwrap()); diff --git a/components/script/dom/htmlmediaelement.rs b/components/script/dom/htmlmediaelement.rs index 0627bcf0ffb..09a1b7cc438 100644 --- a/components/script/dom/htmlmediaelement.rs +++ b/components/script/dom/htmlmediaelement.rs @@ -521,11 +521,10 @@ impl HTMLMediaElement { let context = Arc::new(Mutex::new(HTMLMediaElementContext::new(self, url.clone()))); let (action_sender, action_receiver) = ipc::channel().unwrap(); let window = window_from_node(self); - let script_chan = window.networking_task_source(); let listener = NetworkListener { context: context, - script_chan: script_chan, - wrapper: Some(window.get_runnable_wrapper()), + task_source: window.networking_task_source(), + wrapper: Some(window.get_runnable_wrapper()) }; ROUTER.add_route(action_receiver.to_opaque(), box move |message| { diff --git a/components/script/dom/htmlscriptelement.rs b/components/script/dom/htmlscriptelement.rs index 86e0987b666..68b65f93142 100644 --- a/components/script/dom/htmlscriptelement.rs +++ b/components/script/dom/htmlscriptelement.rs @@ -262,8 +262,8 @@ fn fetch_a_classic_script(script: &HTMLScriptElement, let (action_sender, action_receiver) = ipc::channel().unwrap(); let listener = NetworkListener { context: context, - script_chan: doc.window().networking_task_source(), - wrapper: Some(doc.window().get_runnable_wrapper()), + task_source: doc.window().networking_task_source(), + wrapper: Some(doc.window().get_runnable_wrapper()) }; ROUTER.add_route(action_receiver.to_opaque(), box move |message| { diff --git a/components/script/dom/webidls/EventSource.webidl b/components/script/dom/webidls/EventSource.webidl index b9cf82d6a3e..11c30e959d4 100644 --- a/components/script/dom/webidls/EventSource.webidl +++ b/components/script/dom/webidls/EventSource.webidl @@ -7,8 +7,7 @@ */ [Constructor(DOMString url, optional EventSourceInit eventSourceInitDict), - Exposed=(Window,Worker), - Pref="dom.eventsource.enabled"] + Exposed=(Window,Worker)] interface EventSource : EventTarget { readonly attribute DOMString url; readonly attribute boolean withCredentials; diff --git a/components/script/dom/websocket.rs b/components/script/dom/websocket.rs index dd49f62d247..1764db20764 100644 --- a/components/script/dom/websocket.rs +++ b/components/script/dom/websocket.rs @@ -33,14 +33,16 @@ use net_traits::CoreResourceMsg::{SetCookiesForUrl, WebsocketConnect}; use net_traits::MessageData; use net_traits::hosts::replace_hosts; use net_traits::unwrap_websocket_protocol; -use script_runtime::{CommonScriptMsg, ScriptChan}; +use script_runtime::CommonScriptMsg; use script_runtime::ScriptThreadEventCategory::WebSocketEvent; -use script_thread::Runnable; +use script_thread::{Runnable, RunnableWrapper}; use std::ascii::AsciiExt; use std::borrow::ToOwned; use std::cell::Cell; use std::ptr; use std::thread; +use task_source::TaskSource; +use task_source::networking::NetworkingTaskSource; use websocket::client::request::Url; use websocket::header::{Headers, WebSocketProtocol}; use websocket::ws::util::url::parse_url; @@ -141,7 +143,8 @@ mod close_code { } pub fn close_the_websocket_connection(address: Trusted<WebSocket>, - sender: Box<ScriptChan>, + task_source: &NetworkingTaskSource, + wrapper: &RunnableWrapper, code: Option<u16>, reason: String) { let close_task = box CloseTask { @@ -150,17 +153,19 @@ pub fn close_the_websocket_connection(address: Trusted<WebSocket>, code: code, reason: Some(reason), }; - sender.send(CommonScriptMsg::RunnableMsg(WebSocketEvent, close_task)).unwrap(); + task_source.queue_with_wrapper(close_task, &wrapper).unwrap(); } -pub fn fail_the_websocket_connection(address: Trusted<WebSocket>, sender: Box<ScriptChan>) { +pub fn fail_the_websocket_connection(address: Trusted<WebSocket>, + task_source: &NetworkingTaskSource, + wrapper: &RunnableWrapper) { let close_task = box CloseTask { address: address, failed: true, code: Some(close_code::ABNORMAL), reason: None, }; - sender.send(CommonScriptMsg::RunnableMsg(WebSocketEvent, close_task)).unwrap(); + task_source.queue_with_wrapper(close_task, &wrapper).unwrap(); } #[dom_struct] @@ -268,7 +273,8 @@ impl WebSocket { *ws.sender.borrow_mut() = Some(dom_action_sender); let moved_address = address.clone(); - let sender = global.networking_task_source(); + let task_source = global.networking_task_source(); + let wrapper = global.get_runnable_wrapper(); thread::spawn(move || { while let Ok(event) = dom_event_receiver.recv() { match event { @@ -278,20 +284,22 @@ impl WebSocket { headers: headers, protocols: protocols, }; - sender.send(CommonScriptMsg::RunnableMsg(WebSocketEvent, open_thread)).unwrap(); + task_source.queue_with_wrapper(open_thread, &wrapper).unwrap(); }, WebSocketNetworkEvent::MessageReceived(message) => { let message_thread = box MessageReceivedTask { address: moved_address.clone(), message: message, }; - sender.send(CommonScriptMsg::RunnableMsg(WebSocketEvent, message_thread)).unwrap(); + task_source.queue_with_wrapper(message_thread, &wrapper).unwrap(); }, WebSocketNetworkEvent::Fail => { - fail_the_websocket_connection(moved_address.clone(), sender.clone()); + fail_the_websocket_connection(moved_address.clone(), + &task_source, &wrapper); }, WebSocketNetworkEvent::Close(code, reason) => { - close_the_websocket_connection(moved_address.clone(), sender.clone(), code, reason); + close_the_websocket_connection(moved_address.clone(), + &task_source, &wrapper, code, reason); }, } } @@ -436,8 +444,8 @@ impl WebSocketMethods for WebSocket { self.ready_state.set(WebSocketRequestState::Closing); let address = Trusted::new(self); - let sender = self.global().networking_task_source(); - fail_the_websocket_connection(address, sender); + let task_source = self.global().networking_task_source(); + fail_the_websocket_connection(address, &task_source, &self.global().get_runnable_wrapper()); } WebSocketRequestState::Open => { self.ready_state.set(WebSocketRequestState::Closing); @@ -470,8 +478,8 @@ impl Runnable for ConnectionEstablishedTask { // Step 1: Protocols. if !self.protocols.is_empty() && self.headers.get::<WebSocketProtocol>().is_none() { - let sender = ws.global().networking_task_source(); - fail_the_websocket_connection(self.address, sender); + let task_source = ws.global().networking_task_source(); + fail_the_websocket_connection(self.address, &task_source, &ws.global().get_runnable_wrapper()); return; } diff --git a/components/script/dom/window.rs b/components/script/dom/window.rs index a78dcda8893..63485e45dfc 100644 --- a/components/script/dom/window.rs +++ b/components/script/dom/window.rs @@ -267,7 +267,7 @@ impl Window { self.user_interaction_task_source.clone() } - pub fn networking_task_source(&self) -> Box<ScriptChan + Send> { + pub fn networking_task_source(&self) -> NetworkingTaskSource { self.networking_task_source.clone() } diff --git a/components/script/dom/workerglobalscope.rs b/components/script/dom/workerglobalscope.rs index 2efa2920cb8..041ce8448de 100644 --- a/components/script/dom/workerglobalscope.rs +++ b/components/script/dom/workerglobalscope.rs @@ -41,6 +41,7 @@ use std::sync::Arc; use std::sync::atomic::{AtomicBool, Ordering}; use std::sync::mpsc::Receiver; use task_source::file_reading::FileReadingTaskSource; +use task_source::networking::NetworkingTaskSource; use timers::{IsInterval, TimerCallback}; use url::Url; @@ -361,6 +362,10 @@ impl WorkerGlobalScope { FileReadingTaskSource(self.script_chan()) } + pub fn networking_task_source(&self) -> NetworkingTaskSource { + NetworkingTaskSource(self.script_chan()) + } + pub fn new_script_pair(&self) -> (Box<ScriptChan + Send>, Box<ScriptPort + Send>) { let dedicated = self.downcast::<DedicatedWorkerGlobalScope>(); if let Some(dedicated) = dedicated { diff --git a/components/script/dom/xmlhttprequest.rs b/components/script/dom/xmlhttprequest.rs index ab603f5c444..c07f445a27b 100644 --- a/components/script/dom/xmlhttprequest.rs +++ b/components/script/dom/xmlhttprequest.rs @@ -49,13 +49,12 @@ use js::jsapi::{JSContext, JS_ParseJSON}; use js::jsapi::JS_ClearPendingException; use js::jsval::{JSVal, NullValue, UndefinedValue}; use msg::constellation_msg::PipelineId; -use net_traits::{CoreResourceThread, FetchMetadata, FilteredMetadata}; +use net_traits::{FetchMetadata, FilteredMetadata}; use net_traits::{FetchResponseListener, LoadOrigin, NetworkError, ReferrerPolicy}; use net_traits::CoreResourceMsg::Fetch; use net_traits::request::{CredentialsMode, Destination, RequestInit, RequestMode}; use net_traits::trim_http_whitespace; use network_listener::{NetworkListener, PreInvoke}; -use script_runtime::ScriptChan; use servo_atoms::Atom; use std::ascii::AsciiExt; use std::borrow::ToOwned; @@ -63,6 +62,7 @@ use std::cell::Cell; use std::default::Default; use std::str; use std::sync::{Arc, Mutex}; +use task_source::networking::NetworkingTaskSource; use time; use timers::{OneshotTimerCallback, OneshotTimerHandle}; use url::{Position, Url}; @@ -214,8 +214,8 @@ impl XMLHttpRequest { } fn initiate_async_xhr(context: Arc<Mutex<XHRContext>>, - script_chan: Box<ScriptChan + Send>, - core_resource_thread: CoreResourceThread, + task_source: NetworkingTaskSource, + global: &GlobalScope, init: RequestInit) { impl FetchResponseListener for XHRContext { fn process_request_body(&mut self) { @@ -262,13 +262,13 @@ impl XMLHttpRequest { let (action_sender, action_receiver) = ipc::channel().unwrap(); let listener = NetworkListener { context: context, - script_chan: script_chan, - wrapper: None, + task_source: task_source, + wrapper: Some(global.get_runnable_wrapper()) }; ROUTER.add_route(action_receiver.to_opaque(), box move |message| { listener.notify_fetch(message.to().unwrap()); }); - core_resource_thread.send(Fetch(init, action_sender)).unwrap(); + global.core_resource_thread().send(Fetch(init, action_sender)).unwrap(); } } @@ -1293,16 +1293,15 @@ impl XMLHttpRequest { sync_status: DOMRefCell::new(None), })); - let (script_chan, script_port) = if self.sync.get() { + let (task_source, script_port) = if self.sync.get() { let (tx, rx) = global.new_script_pair(); - (tx, Some(rx)) + (NetworkingTaskSource(tx), Some(rx)) } else { (global.networking_task_source(), None) }; - let core_resource_thread = global.core_resource_thread(); - XMLHttpRequest::initiate_async_xhr(context.clone(), script_chan, - core_resource_thread, init); + XMLHttpRequest::initiate_async_xhr(context.clone(), task_source, + global, init); if let Some(script_port) = script_port { loop { diff --git a/components/script/fetch.rs b/components/script/fetch.rs index ed1a66fc683..740099344bf 100644 --- a/components/script/fetch.rs +++ b/components/script/fetch.rs @@ -2,10 +2,10 @@ * License, v. 2.0. If a copy of the MPL was not distributed with this * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ +use dom::bindings::codegen::Bindings::RequestBinding::RequestInfo; use dom::bindings::codegen::Bindings::RequestBinding::RequestInit; use dom::bindings::codegen::Bindings::ResponseBinding::ResponseBinding::ResponseMethods; use dom::bindings::codegen::Bindings::ResponseBinding::ResponseType as DOMResponseType; -use dom::bindings::codegen::UnionTypes::RequestOrUSVString; use dom::bindings::error::Error; use dom::bindings::js::Root; use dom::bindings::refcounted::{Trusted, TrustedPromise}; @@ -62,12 +62,13 @@ fn request_init_from_request(request: NetTraitsRequest) -> NetTraitsRequestInit referrer_policy: request.referrer_policy.get(), pipeline_id: request.pipeline_id.get(), redirect_mode: request.redirect_mode.get(), + ..NetTraitsRequestInit::default() } } // https://fetch.spec.whatwg.org/#fetch-method #[allow(unrooted_must_root)] -pub fn Fetch(global: &GlobalScope, input: RequestOrUSVString, init: &RequestInit) -> Rc<Promise> { +pub fn Fetch(global: &GlobalScope, input: RequestInfo, init: &RequestInit) -> Rc<Promise> { let core_resource_thread = global.core_resource_thread(); // Step 1 @@ -96,8 +97,8 @@ pub fn Fetch(global: &GlobalScope, input: RequestOrUSVString, init: &RequestInit })); let listener = NetworkListener { context: fetch_context, - script_chan: global.networking_task_source(), - wrapper: None, + task_source: global.networking_task_source(), + wrapper: Some(global.get_runnable_wrapper()) }; ROUTER.add_route(action_receiver.to_opaque(), box move |message| { diff --git a/components/script/lib.rs b/components/script/lib.rs index 91ccc817cf8..ed3283868d5 100644 --- a/components/script/lib.rs +++ b/components/script/lib.rs @@ -48,6 +48,7 @@ extern crate heapsize; #[macro_use] extern crate heapsize_derive; extern crate html5ever; #[macro_use] extern crate html5ever_atoms; +#[macro_use] extern crate hyper; extern crate hyper_serde; extern crate image; diff --git a/components/script/network_listener.rs b/components/script/network_listener.rs index cd0158409f1..5a96317fb18 100644 --- a/components/script/network_listener.rs +++ b/components/script/network_listener.rs @@ -4,16 +4,16 @@ use bluetooth_traits::{BluetoothResponseListener, BluetoothResponseResult}; use net_traits::{Action, FetchResponseListener, FetchResponseMsg}; -use script_runtime::{CommonScriptMsg, ScriptChan}; -use script_runtime::ScriptThreadEventCategory::NetworkEvent; use script_thread::{Runnable, RunnableWrapper}; use std::sync::{Arc, Mutex}; +use task_source::TaskSource; +use task_source::networking::NetworkingTaskSource; /// An off-thread sink for async network event runnables. All such events are forwarded to /// a target thread, where they are invoked on the provided context object. pub struct NetworkListener<Listener: PreInvoke + Send + 'static> { pub context: Arc<Mutex<Listener>>, - pub script_chan: Box<ScriptChan + Send>, + pub task_source: NetworkingTaskSource, pub wrapper: Option<RunnableWrapper>, } @@ -24,9 +24,9 @@ impl<Listener: PreInvoke + Send + 'static> NetworkListener<Listener> { action: action, }; let result = if let Some(ref wrapper) = self.wrapper { - self.script_chan.send(CommonScriptMsg::RunnableMsg(NetworkEvent, wrapper.wrap_runnable(runnable))) + self.task_source.queue_with_wrapper(runnable, wrapper) } else { - self.script_chan.send(CommonScriptMsg::RunnableMsg(NetworkEvent, runnable)) + self.task_source.queue_wrapperless(runnable) }; if let Err(err) = result { warn!("failed to deliver network data: {:?}", err); diff --git a/components/script/script_thread.rs b/components/script/script_thread.rs index cccfbda842d..403dafda0cb 100644 --- a/components/script/script_thread.rs +++ b/components/script/script_thread.rs @@ -659,7 +659,7 @@ impl ScriptThread { chan: MainThreadScriptChan(chan.clone()), dom_manipulation_task_source: DOMManipulationTaskSource(chan.clone()), user_interaction_task_source: UserInteractionTaskSource(chan.clone()), - networking_task_source: NetworkingTaskSource(chan.clone()), + networking_task_source: NetworkingTaskSource(boxed_script_sender.clone()), history_traversal_task_source: HistoryTraversalTaskSource(chan), file_reading_task_source: FileReadingTaskSource(boxed_script_sender), @@ -1623,7 +1623,6 @@ impl ScriptThread { let MainThreadScriptChan(ref sender) = self.chan; let DOMManipulationTaskSource(ref dom_sender) = self.dom_manipulation_task_source; let UserInteractionTaskSource(ref user_sender) = self.user_interaction_task_source; - let NetworkingTaskSource(ref network_sender) = self.networking_task_source; let HistoryTraversalTaskSource(ref history_sender) = self.history_traversal_task_source; let (ipc_timer_event_chan, ipc_timer_event_port) = ipc::channel().unwrap(); @@ -1635,7 +1634,7 @@ impl ScriptThread { MainThreadScriptChan(sender.clone()), DOMManipulationTaskSource(dom_sender.clone()), UserInteractionTaskSource(user_sender.clone()), - NetworkingTaskSource(network_sender.clone()), + self.networking_task_source.clone(), HistoryTraversalTaskSource(history_sender.clone()), self.file_reading_task_source.clone(), self.image_cache_channel.clone(), @@ -2050,7 +2049,7 @@ impl ScriptThread { let (action_sender, action_receiver) = ipc::channel().unwrap(); let listener = NetworkListener { context: context, - script_chan: self.chan.clone(), + task_source: self.networking_task_source.clone(), wrapper: None, }; ROUTER.add_route(action_receiver.to_opaque(), box move |message| { diff --git a/components/script/task_source/networking.rs b/components/script/task_source/networking.rs index 4f85ac6c3e6..8306a4789bb 100644 --- a/components/script/task_source/networking.rs +++ b/components/script/task_source/networking.rs @@ -2,19 +2,32 @@ * License, v. 2.0. If a copy of the MPL was not distributed with this * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ -use script_runtime::{CommonScriptMsg, ScriptChan}; -use script_thread::MainThreadScriptMsg; -use std::sync::mpsc::Sender; +use script_runtime::{CommonScriptMsg, ScriptChan, ScriptThreadEventCategory}; +use script_thread::{Runnable, RunnableWrapper}; +use task_source::TaskSource; #[derive(JSTraceable)] -pub struct NetworkingTaskSource(pub Sender<MainThreadScriptMsg>); +pub struct NetworkingTaskSource(pub Box<ScriptChan + Send + 'static>); -impl ScriptChan for NetworkingTaskSource { - fn send(&self, msg: CommonScriptMsg) -> Result<(), ()> { - self.0.send(MainThreadScriptMsg::Common(msg)).map_err(|_| ()) +impl Clone for NetworkingTaskSource { + fn clone(&self) -> NetworkingTaskSource { + NetworkingTaskSource(self.0.clone()) } +} + +impl TaskSource for NetworkingTaskSource { + fn queue_with_wrapper<T>(&self, + msg: Box<T>, + wrapper: &RunnableWrapper) + -> Result<(), ()> + where T: Runnable + Send + 'static { + self.0.send(CommonScriptMsg::RunnableMsg(ScriptThreadEventCategory::NetworkEvent, + wrapper.wrap_runnable(msg))) + } +} - fn clone(&self) -> Box<ScriptChan + Send> { - box NetworkingTaskSource((&self.0).clone()) +impl NetworkingTaskSource { + pub fn queue_wrapperless<T: Runnable + Send + 'static>(&self, msg: Box<T>) -> Result<(), ()> { + self.0.send(CommonScriptMsg::RunnableMsg(ScriptThreadEventCategory::NetworkEvent, msg)) } } diff --git a/components/script/timers.rs b/components/script/timers.rs index 34ac02b6589..6b67d6959e3 100644 --- a/components/script/timers.rs +++ b/components/script/timers.rs @@ -7,6 +7,7 @@ use dom::bindings::cell::DOMRefCell; use dom::bindings::codegen::Bindings::FunctionBinding::Function; use dom::bindings::reflector::Reflectable; use dom::bindings::str::DOMString; +use dom::eventsource::EventSourceTimeoutCallback; use dom::globalscope::GlobalScope; use dom::testbinding::TestBindingCallback; use dom::xmlhttprequest::XHRTimeoutCallback; @@ -67,6 +68,7 @@ struct OneshotTimer { #[derive(JSTraceable, HeapSizeOf)] pub enum OneshotTimerCallback { XhrTimeout(XHRTimeoutCallback), + EventSourceTimeout(EventSourceTimeoutCallback), JsTimer(JsTimerTask), TestBindingCallback(TestBindingCallback), } @@ -75,6 +77,7 @@ impl OneshotTimerCallback { fn invoke<T: Reflectable>(self, this: &T, js_timers: &JsTimers) { match self { OneshotTimerCallback::XhrTimeout(callback) => callback.invoke(), + OneshotTimerCallback::EventSourceTimeout(callback) => callback.invoke(), OneshotTimerCallback::JsTimer(task) => task.invoke(this, js_timers), OneshotTimerCallback::TestBindingCallback(callback) => callback.invoke(), } |