aboutsummaryrefslogtreecommitdiffstats
path: root/components/script/timers.rs
diff options
context:
space:
mode:
Diffstat (limited to 'components/script/timers.rs')
-rw-r--r--components/script/timers.rs9
1 files changed, 8 insertions, 1 deletions
diff --git a/components/script/timers.rs b/components/script/timers.rs
index 4bc4bf37fff..a5e7020095f 100644
--- a/components/script/timers.rs
+++ b/components/script/timers.rs
@@ -500,7 +500,7 @@ impl JsTimerTask {
code_str, rval.handle_mut());
},
InternalTimerCallback::FunctionTimerCallback(ref function, ref arguments) => {
- let arguments = arguments.iter().map(|arg| arg.handle()).collect();
+ let arguments = self.collect_heap_args(arguments);
let _ = function.Call_(this, arguments, Report);
},
};
@@ -516,4 +516,11 @@ impl JsTimerTask {
timers.initialize_and_schedule(&this.global(), self);
}
}
+
+ // Returning Handles directly from Heap values is inherently unsafe, but here it's
+ // always done via rooted JsTimers, which is safe.
+ #[allow(unsafe_code)]
+ fn collect_heap_args(&self, args: &[Heap<JSVal>]) -> Vec<HandleValue> {
+ args.iter().map(|arg| unsafe { arg.handle() }).collect()
+ }
}