aboutsummaryrefslogtreecommitdiffstats
path: root/components/script/dom
diff options
context:
space:
mode:
Diffstat (limited to 'components/script/dom')
-rw-r--r--components/script/dom/bindings/js.rs2
-rw-r--r--components/script/dom/document.rs2
-rw-r--r--components/script/dom/node.rs10
3 files changed, 7 insertions, 7 deletions
diff --git a/components/script/dom/bindings/js.rs b/components/script/dom/bindings/js.rs
index b370b3a073f..7ada9f45d14 100644
--- a/components/script/dom/bindings/js.rs
+++ b/components/script/dom/bindings/js.rs
@@ -727,7 +727,7 @@ impl<'a, T> Clone for JSRef<'a, T> {
}
}
-impl<'a, T> PartialEq for JSRef<'a, T> {
+impl<'a, 'b, T> PartialEq<JSRef<'b, T>> for JSRef<'a, T> {
fn eq(&self, other: &JSRef<T>) -> bool {
self.ptr == other.ptr
}
diff --git a/components/script/dom/document.rs b/components/script/dom/document.rs
index 059f568f873..ffa22a48182 100644
--- a/components/script/dom/document.rs
+++ b/components/script/dom/document.rs
@@ -244,7 +244,7 @@ impl<'a> DocumentHelpers<'a> for JSRef<'a, Document> {
let browser_context = browser_context.as_ref().unwrap();
let active_document = browser_context.active_document().root();
- if self.clone() != active_document.r() {
+ if self != active_document.r() {
return false;
}
// FIXME: It should also check whether the browser context is top-level or not
diff --git a/components/script/dom/node.rs b/components/script/dom/node.rs
index a0486e6ee11..b6f4e86307b 100644
--- a/components/script/dom/node.rs
+++ b/components/script/dom/node.rs
@@ -409,7 +409,7 @@ pub trait NodeHelpers<'a> {
fn child_elements(self) -> ChildElementIterator<'a>;
fn following_siblings(self) -> NodeChildrenIterator<'a>;
fn is_in_doc(self) -> bool;
- fn is_inclusive_ancestor_of(self, parent: JSRef<'a, Node>) -> bool; // FIXME: See #3960
+ fn is_inclusive_ancestor_of(self, parent: JSRef<Node>) -> bool;
fn is_parent_of(self, child: JSRef<Node>) -> bool;
fn type_id(self) -> NodeTypeId;
@@ -724,7 +724,7 @@ impl<'a> NodeHelpers<'a> for JSRef<'a, Node> {
}
}
- fn is_inclusive_ancestor_of(self, parent: JSRef<'a, Node>) -> bool {
+ fn is_inclusive_ancestor_of(self, parent: JSRef<Node>) -> bool {
self == parent || parent.ancestors().any(|ancestor| ancestor == self)
}
@@ -1385,7 +1385,7 @@ impl Node {
// Step 7-8.
let reference_child = match child {
- Some(child) if child.clone() == node => node.next_sibling().map(|node| node.root().get_unsound_ref_forever()),
+ Some(child) if child == node => node.next_sibling().map(|node| node.root().get_unsound_ref_forever()),
_ => child
};
@@ -1955,7 +1955,7 @@ impl<'a> NodeMethods for JSRef<'a, Node> {
}
// Ok if not caught by previous error checks.
- if node.clone() == child {
+ if node == child {
return Ok(Temporary::from_rooted(child));
}
@@ -2115,7 +2115,7 @@ impl<'a> NodeMethods for JSRef<'a, Node> {
// http://dom.spec.whatwg.org/#dom-node-comparedocumentposition
fn CompareDocumentPosition(self, other: JSRef<Node>) -> u16 {
- if self.clone() == other { // FIXME: See issue #3960
+ if self == other {
// step 2.
0
} else {