diff options
| author | Martin Robinson <mrobinson@igalia.com> | 2025-04-25 22:25:10 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-04-25 20:25:10 +0000 |
| commit | a62f0eaf0a7bfdea47e6132f9042d4b3adb6d3e3 (patch) | |
| tree | bdb1d0492a07f613c5baa1b6194c915db05e1b91 /tests | |
| parent | 69605d05cfab21824d8ab4777cb371cae38aaeb6 (diff) | |
| download | servo-a62f0eaf0a7bfdea47e6132f9042d4b3adb6d3e3.tar.gz servo-a62f0eaf0a7bfdea47e6132f9042d4b3adb6d3e3.zip | |
layout: Use box tree `Fragment`s for offset parent queries (#36681)
This change switches `offsetParent`, `offsetLeft`, etc queries to use
the BoxTree fragments instead of walking the entire fragment tree. In
addition, fragments are stored for columns and colgroups. In general,
this greatly simplifies the flow of the query and prevents having to do
expensive tree walks.
Testing: This change is covered by newly passing WPT tests and three new
failures:
- /css/filter-effects/backdrop-filter-edge-clipping-2.html
- /css/filter-effects/backdrop-filter-edge-mirror.html
- /css/filter-effects/backdrop-filter-edge-pixels-2.html
These failures are actually progressions, because now the references
start
to render properly whereas before they did not.
Fixes: This is part of #36525 and #36665.
Signed-off-by: Martin Robinson <mrobinson@igalia.com>
Co-authored-by: Oriol Brufau <obrufau@igalia.com>
Diffstat (limited to 'tests')
6 files changed, 6 insertions, 30 deletions
diff --git a/tests/wpt/meta/css/cssom-view/offsetParent-block-in-inline.html.ini b/tests/wpt/meta/css/cssom-view/offsetParent-block-in-inline.html.ini deleted file mode 100644 index aa1109f1600..00000000000 --- a/tests/wpt/meta/css/cssom-view/offsetParent-block-in-inline.html.ini +++ /dev/null @@ -1,3 +0,0 @@ -[offsetParent-block-in-inline.html] - [offsetParent-block-in-inline] - expected: FAIL diff --git a/tests/wpt/meta/css/filter-effects/backdrop-filter-edge-clipping-2.html.ini b/tests/wpt/meta/css/filter-effects/backdrop-filter-edge-clipping-2.html.ini new file mode 100644 index 00000000000..4a08b41acc2 --- /dev/null +++ b/tests/wpt/meta/css/filter-effects/backdrop-filter-edge-clipping-2.html.ini @@ -0,0 +1,2 @@ +[backdrop-filter-edge-clipping-2.html] + expected: FAIL diff --git a/tests/wpt/meta/css/filter-effects/backdrop-filter-edge-mirror.html.ini b/tests/wpt/meta/css/filter-effects/backdrop-filter-edge-mirror.html.ini new file mode 100644 index 00000000000..51318cbb1d2 --- /dev/null +++ b/tests/wpt/meta/css/filter-effects/backdrop-filter-edge-mirror.html.ini @@ -0,0 +1,2 @@ +[backdrop-filter-edge-mirror.html] + expected: FAIL diff --git a/tests/wpt/meta/css/filter-effects/backdrop-filter-edge-pixels-2.html.ini b/tests/wpt/meta/css/filter-effects/backdrop-filter-edge-pixels-2.html.ini new file mode 100644 index 00000000000..19d53f587ad --- /dev/null +++ b/tests/wpt/meta/css/filter-effects/backdrop-filter-edge-pixels-2.html.ini @@ -0,0 +1,2 @@ +[backdrop-filter-edge-pixels-2.html] + expected: FAIL diff --git a/tests/wpt/meta/shadow-dom/offsetParent-across-shadow-boundaries.html.ini b/tests/wpt/meta/shadow-dom/offsetParent-across-shadow-boundaries.html.ini deleted file mode 100644 index afd8ee2cf06..00000000000 --- a/tests/wpt/meta/shadow-dom/offsetParent-across-shadow-boundaries.html.ini +++ /dev/null @@ -1,24 +0,0 @@ -[offsetParent-across-shadow-boundaries.html] - [offsetParent must skip offset parents of an element when the context object is assigned to a slot in a shadow tree of open mode] - expected: FAIL - - [offsetParent must skip offset parents of an element when the context object is assigned to a slot in a shadow tree of closed mode] - expected: FAIL - - [offsetParent must skip multiple offset parents of an element when the context object is assigned to a slot in a shadow tree of open mode] - expected: FAIL - - [offsetParent must skip multiple offset parents of an element when the context object is assigned to a slot in a shadow tree of closed mode] - expected: FAIL - - [offsetParent must skip offset parents of an element when the context object is assigned to a slot in nested shadow trees of open mode] - expected: FAIL - - [offsetParent must skip offset parents of an element when the context object is assigned to a slot in nested shadow trees of closed mode] - expected: FAIL - - [offsetParent must find the first offset parent which is a shadow-including ancestor of the context object even some shadow tree of open mode did not have any offset parent] - expected: FAIL - - [offsetParent must find the first offset parent which is a shadow-including ancestor of the context object even some shadow tree of closed mode did not have any offset parent] - expected: FAIL diff --git a/tests/wpt/meta/shadow-dom/offsetTop-offsetLeft-across-shadow-boundaries.html.ini b/tests/wpt/meta/shadow-dom/offsetTop-offsetLeft-across-shadow-boundaries.html.ini index 88f45f3b6a7..5ebeb149de3 100644 --- a/tests/wpt/meta/shadow-dom/offsetTop-offsetLeft-across-shadow-boundaries.html.ini +++ b/tests/wpt/meta/shadow-dom/offsetTop-offsetLeft-across-shadow-boundaries.html.ini @@ -4,6 +4,3 @@ [Verifies that HTMLElement.offsetTop accounts for shadow boundaries when nested in multiple shadow roots.] expected: FAIL - - [Verifies that HTMLElement.offsetLeft accounts for shadow boundaries.] - expected: FAIL |