aboutsummaryrefslogtreecommitdiffstats
path: root/tests
diff options
context:
space:
mode:
authorbors-servo <lbergstrom+bors@mozilla.com>2019-04-23 16:49:12 -0400
committerGitHub <noreply@github.com>2019-04-23 16:49:12 -0400
commit03b005c7b28fe887ff97e109392ecf2983e6f8c0 (patch)
tree21b77a9fc29382aafb7779fb253d1a198a592902 /tests
parent4c8d29f5a7fb457cee3144b708c9e51142c2779a (diff)
parentfdbec9835cfbde0b09c9f1f8594dce81af73c1ff (diff)
downloadservo-03b005c7b28fe887ff97e109392ecf2983e6f8c0.tar.gz
servo-03b005c7b28fe887ff97e109392ecf2983e6f8c0.zip
Auto merge of #23178 - tdelacour:ISSUE-21263, r=jdm
Add PerformanceResourceTiming: ResponseEnd <!-- Please describe your changes on the following line: --> 1. Added `ResponseEnd` to `ResourceAttribute` enum in `net_traits` and added it to the `set_attribute` function on `ResourceFetchTiming` 2. Added `response_end` field to `performanceresourcetiming.rs` 3. In `http_loader.rs`, set ResponseEnd after response body read is complete, or before return due to network error. I could use a little guidance on testing. After building and running `wpt` tests, I noticed that some tests now "Pass" when they were expected to "Fail". As per the wiki instructions, I've removed those expectations from the `metadata`. I noticed that there are a handful of other "failing" test expectations associated with `responseEnd`, but those still do not pass. I looked through some similar PRs (`connectEnd`, `redirectStart`, etc) and saw that they also still have a few failing test expectations here and there. Does that mean this is OK for now? How can I better understand which tests we expect to resolve for a given issue? Thanks! --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #21263 (GitHub issue number if applicable) <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23178) <!-- Reviewable:end -->
Diffstat (limited to 'tests')
-rw-r--r--tests/wpt/metadata/resource-timing/idlharness.any.js.ini9
-rw-r--r--tests/wpt/metadata/resource-timing/resource_reuse.sub.html.ini3
2 files changed, 0 insertions, 12 deletions
diff --git a/tests/wpt/metadata/resource-timing/idlharness.any.js.ini b/tests/wpt/metadata/resource-timing/idlharness.any.js.ini
index 09f0ae0a9ee..d5afd6d78d9 100644
--- a/tests/wpt/metadata/resource-timing/idlharness.any.js.ini
+++ b/tests/wpt/metadata/resource-timing/idlharness.any.js.ini
@@ -35,9 +35,6 @@
[PerformanceResourceTiming interface: resource must inherit property "workerStart" with the proper type]
expected: FAIL
- [PerformanceResourceTiming interface: attribute responseEnd]
- expected: FAIL
-
[PerformanceResourceTiming interface: attribute secureConnectionStart]
expected: FAIL
@@ -59,9 +56,6 @@
[PerformanceResourceTiming interface: attribute connectStart]
expected: FAIL
- [PerformanceResourceTiming interface: resource must inherit property "responseEnd" with the proper type]
- expected: FAIL
-
[PerformanceResourceTiming interface: resource must inherit property "redirectEnd" with the proper type]
expected: FAIL
@@ -154,9 +148,6 @@
[PerformanceResourceTiming must be primary interface of resource]
expected: FAIL
- [PerformanceResourceTiming interface: attribute responseEnd]
- expected: FAIL
-
[PerformanceResourceTiming interface: attribute secureConnectionStart]
expected: FAIL
diff --git a/tests/wpt/metadata/resource-timing/resource_reuse.sub.html.ini b/tests/wpt/metadata/resource-timing/resource_reuse.sub.html.ini
index 521b1636903..c7b33c2cd68 100644
--- a/tests/wpt/metadata/resource-timing/resource_reuse.sub.html.ini
+++ b/tests/wpt/metadata/resource-timing/resource_reuse.sub.html.ini
@@ -8,9 +8,6 @@
[Entry name should end with file name]
expected: FAIL
- [responseEnd should not be before startTime]
- expected: FAIL
-
[requestStart should be non-zero on the same-origin request]
expected: FAIL