diff options
author | elomscansio <163124154+elomscansio@users.noreply.github.com> | 2025-04-28 02:24:43 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2025-04-28 01:24:43 +0000 |
commit | b1d0b6a37bed9512805cfab07da15cca8f750238 (patch) | |
tree | 06c199ddf920ea368f00200da30b6d9324205f5c /tests/wpt/web-platform-tests/css/css-overflow/input-scrollable-region-001.html | |
parent | 2892e7924dd7e18c966ff957d68f0aad308ff19a (diff) | |
download | servo-main.tar.gz servo-main.zip |
This PR updates the validity state revalidation behavior for radio input
elements, ensuring consistent logic regardless of tree connectivity.
---
**What’s changed:**
- we now always update the validity state.
- Handled more edge cases for disconnected trees, shadow roots, and
cross-tree movement.
- Ensured that radio group updates still trigger when a parent is moved
into a different root.
- Updated test expectations in
`radio-disconnected-group-owner.html.ini`.
---
**Why this matters:**
The updated logic aligns better with the [HTML
specification](https://html.spec.whatwg.org/multipage/input.html#radio-button-group),
especially regarding radio group behavior in disconnected trees or
shadow DOM.
These changes improve validity propagation in scenarios like:
- Appending inputs into a disconnected form
- Shadow roots acting as radio group containers
- Cross-tree movement of radio buttons
---
**Tests:**
- Modified `radio-disconnected-group-owner.html.ini`
- Removed a test that now passes
- Added a failing test expectation caused by a spec bug: the fragment
parsing algorithm uses the connected tree for HTML set via `innerHTML`,
affecting radio group computation
---
**Spec reference:**
https://html.spec.whatwg.org/multipage/input.html#radio-button-group
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by
`[X]` when the step is complete, and replace `___` with appropriate
data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report an errors
- [ ] These changes fix #
<!-- Either: -->
- [X] There are tests for these changes
Signed-off-by: Emmanuel Paul Elom <elomemmanuel007@gmail.com>
Diffstat (limited to 'tests/wpt/web-platform-tests/css/css-overflow/input-scrollable-region-001.html')
0 files changed, 0 insertions, 0 deletions