aboutsummaryrefslogtreecommitdiffstats
path: root/tests/unit/style/parsing/mod.rs
diff options
context:
space:
mode:
authorbors-servo <lbergstrom+bors@mozilla.com>2017-04-12 01:16:32 -0500
committerGitHub <noreply@github.com>2017-04-12 01:16:32 -0500
commitc8cd70f333d41864ff7bf7dce84301509c71d1d6 (patch)
treeea19e42a502f3674c0d80f6c7f535531f1ce0199 /tests/unit/style/parsing/mod.rs
parent3c5a21ebf39b31cb77cb1a2e162e4abdac325e74 (diff)
parent7ecee05e4a098788fcb5f2764914411ed8d0ad54 (diff)
downloadservo-c8cd70f333d41864ff7bf7dce84301509c71d1d6.tar.gz
servo-c8cd70f333d41864ff7bf7dce84301509c71d1d6.zip
Auto merge of #16229 - tomhoule:fix-lengths, r=emilio
style: Do not immediately convert absolute specified lengths <!-- Please describe your changes on the following line: --> This PR aims to solve issue #15729. I tried to follow the recommendations there as much as possible. This is my first attempt at contributing to Servo, so this will probably need a lot of input, although I'm eager to make it as polished as possible. - The base inaccuracy issue seems solved, as can be easily verified with the `console.log` based example in the issue. - Very basic unit tests were added. I have doubts mainly about the right way to represent these new enum variants for the various length units: 1. With new enum variants in `NoCalcLength` *and* newtypes (current solution) 2. With a `NoCalcLength::Absolute` variant that contains a new `AbsoluteLength` enum, but without newtypes 3. Same as solution 2 but with newtypes - I mostly cared about unit tests until now but will investigate other types of tests - Tests to check the clamping - Write a proper commit message Thanks for your time and feedback :) --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #15729. <!-- Either: --> - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16229) <!-- Reviewable:end -->
Diffstat (limited to 'tests/unit/style/parsing/mod.rs')
0 files changed, 0 insertions, 0 deletions