diff options
author | bors-servo <infra@servo.org> | 2023-05-22 14:20:59 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-05-22 14:20:59 +0200 |
commit | b7674fcec021e89f9b9c2bc52832fdbdd16ec8df (patch) | |
tree | ff039a1ac967b89e82eed6d7b5fa618cf3895838 /support/magicleap/Servo2D/code/src | |
parent | 445420022981f77ee42992d8c8a445cc03fa13a7 (diff) | |
parent | 84d13eacbda42c37b51ff6082ce705a4c868eb4c (diff) | |
download | servo-b7674fcec021e89f9b9c2bc52832fdbdd16ec8df.tar.gz servo-b7674fcec021e89f9b9c2bc52832fdbdd16ec8df.zip |
Auto merge of #29767 - mukilan:fix-slowness-in-macos-copy-dependencies, r=mrobinson
Fix slowness in macos copy_dependencies
The `copy_dependencies` logic is invoking `change_non_system_libraries_path` with absolute paths to gstreamer *plugin dylibs*.
`change_non_system_libraries_path` skips editing links in servo binary to relocatable dylibs, but the since the plugins have absolute paths, they are treated as 'non-relocable' and it will try to edit the *non-existent* link (since plugins are loaded dynamically) in servo bin . These unnecessary calls to change_link_name is the cause of the slowness identified in #29764
This PR fixes the issue by ensuring plugin dylibs are not passed to the first call to change_non_system_libraries_path that patches the links in the main servo binary.
With this fix, the time taken by copy_dependencies is reduced to ~3 seconds on my system.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #29764
<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because they fix slowness in build step
Diffstat (limited to 'support/magicleap/Servo2D/code/src')
0 files changed, 0 insertions, 0 deletions