aboutsummaryrefslogtreecommitdiffstats
path: root/support/magicleap/Servo2D/code/inc/Servo2D.h
diff options
context:
space:
mode:
authorbors-servo <lbergstrom+bors@mozilla.com>2019-08-09 02:54:33 -0400
committerGitHub <noreply@github.com>2019-08-09 02:54:33 -0400
commit90fb4c3589718805f0b6d83c5e74222cf6234cb9 (patch)
tree075e6d0be4f03812bdd68a245f88b538c2cc39c9 /support/magicleap/Servo2D/code/inc/Servo2D.h
parentda559d47b93854e4c7d4acf0a0d2029a9e643794 (diff)
parent28e64fc701fc4a5f2f2e2dafe841465fe87e036c (diff)
downloadservo-90fb4c3589718805f0b6d83c5e74222cf6234cb9.tar.gz
servo-90fb4c3589718805f0b6d83c5e74222cf6234cb9.zip
Auto merge of #23930 - CYBAI:incumbent-global-assertion, r=jdm
Assert incumbent global is always some in get_incumbent_global hook While working on module script, I'd like to use Promise with a custom callback with type `Box<dyn TaskBox>` which means we didn't use web API callbacks as native handlers. However, we'll get a panic from `enqueue_promise_job` and the panic says we have a `null` incumbent global. The main problem here is, the Promise API is strongly tied to JS engine and it always assumes there's a meaningful answer for "what specific global is this promise associated with". So, when I don't use the Promise for a specific web API, our engine cannot find a proper incumbent global for us so that we get the `null` incumbent global panic. To make us catch this case easier in the future, we should add the assertion inside `get_incumbent_global` hook so that we can know this quickly next time. Ref: https://mozilla.logbot.info/servo/20190807#c16525481 --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because it should just add assertion inside the hook <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23930) <!-- Reviewable:end -->
Diffstat (limited to 'support/magicleap/Servo2D/code/inc/Servo2D.h')
0 files changed, 0 insertions, 0 deletions