auto merge of #899 : metajack/servo/create-element, r=jdm

This re-uses the parser's node creation code. That could probably be put
somewhere nicer. Suggestions welcome!

2 files changed, 16 insertions, 5 deletions

diff --git a/src/components/script/dom/bindings/codegen/Document.webidl b/src/components/script/dom/bindings/codegen/Document.webidl
index 2e61ae1a27e..40bc8b836a3 100644
--- a/src/components/script/dom/bindings/codegen/Document.webidl
+++ b/src/components/script/dom/bindings/codegen/Document.webidl
@@ -45,10 +45,10 @@ interface Document /*: Node*/ { //XXXjdm Requires servo/#623
   [Creator, Throws]
   Element createElementNS(DOMString? namespace, DOMString qualifiedName);
   /*[Creator]
-    DocumentFragment createDocumentFragment();
+  DocumentFragment createDocumentFragment();*/
   [Creator]
   Text createTextNode(DOMString data);
-  [Creator]
+  /*[Creator]
   Comment createComment(DOMString data);
   [Creator, Throws]
   ProcessingInstruction createProcessingInstruction(DOMString target, DOMString data);*/
diff --git a/src/components/script/dom/document.rs b/src/components/script/dom/document.rs
index ca06acbb61e..51352b2faeb 100644
--- a/src/components/script/dom/document.rs
+++ b/src/components/script/dom/document.rs
@@ -17,7 +17,7 @@ use dom::text::Text;
 use dom::window::Window;
 use dom::windowproxy::WindowProxy;
 use dom::htmltitleelement::HTMLTitleElement;
-
+use html::hubbub_html_parser::build_element_from_tag;
 use js::jsapi::{JS_AddObjectRoot, JS_RemoveObjectRoot, JSObject, JSContext, JSVal};
 use js::glue::RUST_OBJECT_TO_JSVAL;
 use servo_util::tree::TreeNodeRef;
@@ -213,6 +213,11 @@ impl Document {
         Some(self.root)
     }
 
+    fn get_cx(&self) -> *JSContext {
+        let win = self.window.get_ref();
+        unsafe {(*win.page).js_info.get_ref().js_compartment.cx.ptr}
+    }
+
     fn get_scope_and_cx(&self) -> (*JSObject, *JSContext) {
         let win = self.window.get_ref();
         let cx = unsafe {(*win.page).js_info.get_ref().js_compartment.cx.ptr};
@@ -239,14 +244,20 @@ impl Document {
         None
     }
 
-    pub fn CreateElement(&self, _local_name: &DOMString, _rv: &mut ErrorResult) -> AbstractNode<ScriptView> {
-        fail!("stub")
+    pub fn CreateElement(&self, local_name: &DOMString, _rv: &mut ErrorResult) -> AbstractNode<ScriptView> {
+        let cx = self.get_cx();
+        build_element_from_tag(cx, local_name.to_str())
     }
 
     pub fn CreateElementNS(&self, _namespace: &DOMString, _qualified_name: &DOMString, _rv: &mut ErrorResult) -> AbstractNode<ScriptView> {
         fail!("stub")
     }
 
+    pub fn CreateTextNode(&self, data: &DOMString) -> AbstractNode<ScriptView> {
+        let cx = self.get_cx();
+        unsafe { Node::as_abstract_node(cx, @Text::new(data.to_str())) }
+    }
+
     pub fn CreateEvent(&self, _interface: &DOMString, _rv: &mut ErrorResult) -> @mut Event {
         fail!("stub")
     }