aboutsummaryrefslogtreecommitdiffstats
path: root/src/components/script/dom/bindings/utils.rs
diff options
context:
space:
mode:
authorMs2ger <ms2ger@gmail.com>2014-07-10 16:40:41 +0200
committerMs2ger <ms2ger@gmail.com>2014-07-10 16:45:41 +0200
commit439bc78cabe2ef23748000b1eb9f345c9206524e (patch)
tree35f69907dffd2e4bae1aa9a8566bb07de0c4391c /src/components/script/dom/bindings/utils.rs
parent360d5d01d86ec15fdfd8e3da62b2c39e731fa0d3 (diff)
downloadservo-439bc78cabe2ef23748000b1eb9f345c9206524e.tar.gz
servo-439bc78cabe2ef23748000b1eb9f345c9206524e.zip
Return a Temporary from *Binding::Wrap.
Returning a JS<T> is GC-unsafe. This commit also includes some cleanup around Node and Document reflection.
Diffstat (limited to 'src/components/script/dom/bindings/utils.rs')
-rw-r--r--src/components/script/dom/bindings/utils.rs4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/components/script/dom/bindings/utils.rs b/src/components/script/dom/bindings/utils.rs
index 2c494c2008e..99398bfc2f8 100644
--- a/src/components/script/dom/bindings/utils.rs
+++ b/src/components/script/dom/bindings/utils.rs
@@ -377,9 +377,9 @@ pub trait Reflectable {
pub fn reflect_dom_object<T: Reflectable>
(obj: Box<T>,
window: &JSRef<window::Window>,
- wrap_fn: extern "Rust" fn(*mut JSContext, &JSRef<window::Window>, Box<T>) -> JS<T>)
+ wrap_fn: extern "Rust" fn(*mut JSContext, &JSRef<window::Window>, Box<T>) -> Temporary<T>)
-> Temporary<T> {
- Temporary::new(wrap_fn(window.deref().get_cx(), window, obj))
+ wrap_fn(window.get_cx(), window, obj)
}
#[allow(raw_pointer_deriving)]