aboutsummaryrefslogtreecommitdiffstats
path: root/python
diff options
context:
space:
mode:
authorMartin Robinson <mrobinson@igalia.com>2023-04-17 09:03:01 +0200
committerMartin Robinson <mrobinson@igalia.com>2023-04-17 09:03:01 +0200
commit61a70fbff2969eedc3efc1fc6c9bc8f73cdb0bc5 (patch)
treebc44ecc2e3e67cb8603c2af317cb7157aeab8ec7 /python
parent6e2615f0b5cf36b54bbada88e8e5317da764108a (diff)
downloadservo-61a70fbff2969eedc3efc1fc6c9bc8f73cdb0bc5.tar.gz
servo-61a70fbff2969eedc3efc1fc6c9bc8f73cdb0bc5.zip
Make errors during build status notification warnings
Instead of raising an exception, simply print a warning on stderr when notification fails. Fixes #29635.
Diffstat (limited to 'python')
-rw-r--r--python/servo/build_commands.py7
1 files changed, 5 insertions, 2 deletions
diff --git a/python/servo/build_commands.py b/python/servo/build_commands.py
index c0c62fb2d1a..2b0624d3a1d 100644
--- a/python/servo/build_commands.py
+++ b/python/servo/build_commands.py
@@ -744,12 +744,15 @@ class MachCommands(CommandBase):
-1 # timeout
)
except ImportError:
- raise Exception("Optional Python module 'dbus' is not installed.")
+ print("[Warning] Could not generate notification: "
+ "Optional Python module 'dbus' is not installed.",
+ file=sys.stderr)
return True
if notify_command:
if call([notify_command, title, message]) != 0:
- raise Exception("Could not run '%s'." % notify_command)
+ print("[Warning] Could not generate notification: "
+ f"Could not run '{notify_command}'.", file=sys.stderr)
else:
notifier = LinuxNotifier if sys.platform.startswith("linux") else None
notification = notifypy.Notify(use_custom_notifier=notifier)