diff options
author | Tim van der Lippe <TimvdLippe@users.noreply.github.com> | 2025-05-04 22:20:56 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2025-05-04 20:20:56 +0000 |
commit | 8a837778d9fe273aa8c3ce5aa9824dcca0c76e6f (patch) | |
tree | 1edae44f27debc14c1ea7fe9977ea45bc445acb9 /python/tidy/tidy_self_test/speclink.rs | |
parent | 3db0194e5aea410ee6980542a52eabae298cc9fd (diff) | |
download | servo-main.tar.gz servo-main.zip |
Rather than sharing the full image cache in a script_thread, the image
cache is now unique per document. This ensures that CSP factors no
longer affect whether the image is retrieved from the cache incorrectly.
To do so, the thread_pool is shared across all caches, but the store is
fresh. Except for the place_holder{image,url}, which are cloned. That's
because the `rippy_data` is only available in the constellation and no
longer accessible at the point that we need to create the document in
the script_thread.
Contrary to the description in #36505, the script_thread still has an
image_cache for this reason: so it has access to the store and
thread_pool to clone it.
With these changes, the two CSP tests no longer flake. Confirmed with
running the following commmand:
```
./mach test-wpt tests/wpt/tests/content-security-policy/generic/ --rerun=10
```
Fixes #36505
Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com>
Diffstat (limited to 'python/tidy/tidy_self_test/speclink.rs')
0 files changed, 0 insertions, 0 deletions