diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2016-11-11 13:33:06 -0600 |
---|---|---|
committer | GitHub <noreply@github.com> | 2016-11-11 13:33:06 -0600 |
commit | d49840eeec30967cc6f482bc2db9055ab6404ea4 (patch) | |
tree | 70230eb15dcd5b574fd09e956c4d19dec58c8701 /python/tidy/servo_tidy_tests | |
parent | 75d35241db63894db31b6385143ffea0db5cac70 (diff) | |
parent | 65f239c9e11cb8a1a95477560c3ef9400c924110 (diff) | |
download | servo-d49840eeec30967cc6f482bc2db9055ab6404ea4.tar.gz servo-d49840eeec30967cc6f482bc2db9055ab6404ea4.zip |
Auto merge of #14167 - emilio:rule-tree-list, r=Manishearth
style: Don't assume siblings are alive in the rule tree when removing ourselves from the child list.
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
<!-- Either: -->
- [x] There are tests for these changes OR
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
We can't assume all our siblings are alive because they may very well be in the
free list too.
This tempts to happen when the rule nodes are destroyed as part of the last GC,
the one that runs in the root destructor.
Also, properly put the next sibling back into the list when the rules are GCd.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14167)
<!-- Reviewable:end -->
Diffstat (limited to 'python/tidy/servo_tidy_tests')
0 files changed, 0 insertions, 0 deletions