diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2017-03-06 07:11:51 -0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2017-03-06 07:11:51 -0800 |
commit | 0dbee36915abd926e61ca8571e11abf1f97ec830 (patch) | |
tree | 536286796d65fe34a355802a5e6aff3e8c4a934f /python/tidy/servo_tidy_tests | |
parent | c62973b77b6ac74c0daf11b1f4c18b9dd64ae400 (diff) | |
parent | f48f0567cf44ac87fb34756b4167b644ad6049db (diff) | |
download | servo-0dbee36915abd926e61ca8571e11abf1f97ec830.tar.gz servo-0dbee36915abd926e61ca8571e11abf1f97ec830.zip |
Auto merge of #15751 - avinash-vijayaraghavan:testing-csserror, r=cbrewster
first stab. added ServoUrl as a parameter to report_error(...) of Par…
@jdm @SimonSapin
<!-- Please describe your changes on the following line: -->
1. Added ServoUrl as a parameter to report_error(...) of ParseErrorReporter trait.
2. I am not sure how to handle the case of impl ParseErrorReporter for CSSErrorReporter and MemoryHoleReporter, so have not made any changes (other than adding ServoUrl arg) to report_error implementations for these.
3. In StdoutErrorReporter i have added the ServoUrl arg to the info! function,
4. I would like to know if i am on the correct path and clarify what else needs to be done.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ X] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #15708 (github issue number if applicable).
<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because wanted to clarify before writing tests
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15751)
<!-- Reviewable:end -->
Diffstat (limited to 'python/tidy/servo_tidy_tests')
0 files changed, 0 insertions, 0 deletions