diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2017-02-24 07:44:48 -0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2017-02-24 07:44:48 -0800 |
commit | 050d9d909749f5d549b4dfdf69690bd1b5486836 (patch) | |
tree | 0c822a6524bf0a2dee8ab5f00ae7a73e99f2f014 /python/tidy/servo_tidy_tests | |
parent | a204c4176dcccdad8ec99d74055c66794c3f64ba (diff) | |
parent | c3da55dd74afae9f474d2ea0a356cbd86552d61f (diff) | |
download | servo-050d9d909749f5d549b4dfdf69690bd1b5486836.tar.gz servo-050d9d909749f5d549b4dfdf69690bd1b5486836.zip |
Auto merge of #15710 - canaltinova:clip, r=emilio
Implement gecko glue for clip property
<!-- Please describe your changes on the following line: -->
Implemented gecko glue for clip property.
Clip property looks slightly different in gecko. `auto` top and left values are preserved as auto in [gecko](http://searchfox.org/mozilla-central/rev/39e4b25a076c59d2e7820297d62319f167871449/layout/style/nsRuleNode.cpp#10294,10316) but converted to 0 in [servo](https://dxr.mozilla.org/servo/rev/65624dbfc28442b58145215f524eb13aeb2cadf6/components/style/values/specified/mod.rs#942). Gecko is setting `NS_STYLE_CLIP_TOP_AUTO` and `NS_STYLE_CLIP_LEFT_AUTO` flags with that information. But I tried this property in stylo build and it is working correctly like this. It looks like it doesn't change the outcome of the property.
~Do we really need to set these flags?~
Manishearth and bz said that auto and 0 values are same.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix [Bug 1341728](https://bugzilla.mozilla.org/show_bug.cgi?id=1341728)
<!-- Either: -->
- [X] These changes do not require tests because this is stylo side change.
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15710)
<!-- Reviewable:end -->
Diffstat (limited to 'python/tidy/servo_tidy_tests')
0 files changed, 0 insertions, 0 deletions