diff options
| author | Martin Robinson <mrobinson@igalia.com> | 2023-03-21 18:52:46 +0100 |
|---|---|---|
| committer | Martin Robinson <mrobinson@igalia.com> | 2023-03-22 15:37:56 +0100 |
| commit | ec9cbeefd88176e4fb85d1066beafa9eec19d51e (patch) | |
| tree | 2dda9ca8c59bce80bec9b0c5cb9d93c8ecb21cf1 /python/tidy/servo_tidy_tests/test_tidy.py | |
| parent | 259ccff4919d5a764fc38cd8ebb0f7eaa0ad12c0 (diff) | |
| download | servo-ec9cbeefd88176e4fb85d1066beafa9eec19d51e.tar.gz servo-ec9cbeefd88176e4fb85d1066beafa9eec19d51e.zip | |
Merge forbidden panic check into test-tidy
This cleans up the GitHub actions yaml a bit and ensures that developers
are running this check locally before submitting changes. In addition,
it allows adding tests for this check. Finally, this change fixes the
tidy tests by upgrading voluptuous for Python 3.10 as well as by
reverting an inadvertent change for NixOS compatibility on one of the
dummy testing files.
Diffstat (limited to 'python/tidy/servo_tidy_tests/test_tidy.py')
| -rw-r--r-- | python/tidy/servo_tidy_tests/test_tidy.py | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/python/tidy/servo_tidy_tests/test_tidy.py b/python/tidy/servo_tidy_tests/test_tidy.py index 3189250143a..6138320cc35 100644 --- a/python/tidy/servo_tidy_tests/test_tidy.py +++ b/python/tidy/servo_tidy_tests/test_tidy.py @@ -115,6 +115,8 @@ class CheckTidiness(unittest.TestCase): self.assertEqual('use &T instead of &DomRoot<T>', next(errors)[2]) self.assertEqual('encountered function signature with -> ()', next(errors)[2]) self.assertEqual('operators should go at the end of the first line', next(errors)[2]) + self.assertEqual('unwrap() or panic!() found in code which should not panic.', next(errors)[2]) + self.assertEqual('unwrap() or panic!() found in code which should not panic.', next(errors)[2]) self.assertNoMoreErrors(errors) feature_errors = tidy.collect_errors_for_files(iterFile('lib.rs'), [], [tidy.check_rust], print_text=False) |