diff options
author | haval0 <56519858+haval0@users.noreply.github.com> | 2025-04-29 21:19:31 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2025-04-29 19:19:31 +0000 |
commit | ec88b5d752e0ed4aed5fcea2620ca520f271fd99 (patch) | |
tree | d4b3526b2eb7217ee1c2b80fb5e198570ebf581a /python/tidy/servo_tidy_tests/lints/no_lint.py | |
parent | bab788f5d541bd18da75331040d4cc6132723de4 (diff) | |
download | servo-ec88b5d752e0ed4aed5fcea2620ca520f271fd99.tar.gz servo-ec88b5d752e0ed4aed5fcea2620ca520f271fd99.zip |
layout: Check if root before establishing containing block (#36360)
As per
[w3.org/TR/filter-effects-1#FilterProperty](https://www.w3.org/TR/filter-effects-1/#FilterProperty),
`filter` shouldn't make the root element establish a containing block
for absolute and fixed positioned descendants. `will-change: filter` has
matching behavior.
This PR adds a check for if we are the root element before establishing
such a block.
To know if we are the root element, we look at the `FragmentFlags`
passed in. Previously for our function, these were dummy flags, always
constructed as empty. Thus, this PR also makes sure the correct
FragmentFlags are passed down the chain to the function
`establishes_containing_block_for_all_descendants`.
Testing:
- `/css/filter-effects/filtered-html-is-not-container.html` now passes
- `/css/css-will-change/will-change-fixedpos-cb-003.html` now passes
- Manual tests are working
Fixes: #35391
---------
Signed-off-by: haval0 <56519858+haval0@users.noreply.github.com>
Signed-off-by: Oriol Brufau <obrufau@igalia.com>
Co-authored-by: Oriol Brufau <obrufau@igalia.com>
Diffstat (limited to 'python/tidy/servo_tidy_tests/lints/no_lint.py')
0 files changed, 0 insertions, 0 deletions