aboutsummaryrefslogtreecommitdiffstats
path: root/python/tidy/servo_tidy/tidy.py
diff options
context:
space:
mode:
authorDaan Sprenkels <dsprenkels@gmail.com>2016-10-30 19:08:14 +0100
committerDaan Sprenkels <dsprenkels@gmail.com>2016-10-31 18:11:35 +0100
commit179e11ad8d834dbbc4fc14209ce0c9b169085df4 (patch)
tree1b7d814c2a5ddab14f9b3cf43fffe33dc1af59d9 /python/tidy/servo_tidy/tidy.py
parent84055461aa84a730342af3c423ea394b170db076 (diff)
downloadservo-179e11ad8d834dbbc4fc14209ce0c9b169085df4.tar.gz
servo-179e11ad8d834dbbc4fc14209ce0c9b169085df4.zip
test-tidy: Check for space between function name and `(`
Disallow an extraneous space in a function call between the function name and the opening parenthesis in Rust code, while ignoring macro declarations. This commit fixes #13980.
Diffstat (limited to 'python/tidy/servo_tidy/tidy.py')
-rw-r--r--python/tidy/servo_tidy/tidy.py7
1 files changed, 7 insertions, 0 deletions
diff --git a/python/tidy/servo_tidy/tidy.py b/python/tidy/servo_tidy/tidy.py
index 1dcbd4896d1..958a703c606 100644
--- a/python/tidy/servo_tidy/tidy.py
+++ b/python/tidy/servo_tidy/tidy.py
@@ -442,6 +442,13 @@ def check_rust(file_name, lines):
regex_rules = [
(r",[^\s]", "missing space after ,",
lambda match, line: '$' not in line and not is_attribute),
+ (r"([A-Za-z0-9_]+) (\()", "extra space after {0}",
+ lambda match, line: not (
+ is_attribute or
+ re.match(r"\bmacro_rules!\s+", line[:match.start()]) or
+ re.search(r"[^']'[A-Za-z0-9_]+ \($", line[:match.end()]) or
+ match.group(1) in ['const', 'fn', 'for', 'if', 'in',
+ 'let', 'match', 'mut', 'return'])),
(r"[A-Za-z0-9\"]=", "missing space before =",
lambda match, line: is_attribute),
(r"=[A-Za-z0-9\"]", "missing space after =",