diff options
| author | hatoo <hato2000@gmail.com> | 2024-08-06 18:35:05 +0900 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-08-06 09:35:05 +0000 |
| commit | 28430bad0e7a4d4c11710d61fbaf1c598bffa87d (patch) | |
| tree | 77eba5485bb1364c78e72b83933133547a008086 /python/servo/visual_studio.py | |
| parent | 3f339d6856283dc4839f6378df5df1ddbedcb5d6 (diff) | |
| download | servo-28430bad0e7a4d4c11710d61fbaf1c598bffa87d.tar.gz servo-28430bad0e7a4d4c11710d61fbaf1c598bffa87d.zip | |
Fix visual_studio.py to call vswhere with -utf8 (#32949)
In Japanese Windows, `vswhere` puts cp932 string in default and fails to
load json in Pyhton.
This fixes it by adding `-utf8` option
Signed-off-by: hatoo <hato2000@gmail.com>
Diffstat (limited to 'python/servo/visual_studio.py')
| -rw-r--r-- | python/servo/visual_studio.py | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/python/servo/visual_studio.py b/python/servo/visual_studio.py index c63ffe2f54c..1c0b99e8c03 100644 --- a/python/servo/visual_studio.py +++ b/python/servo/visual_studio.py @@ -57,7 +57,8 @@ def find_compatible_msvc_with_vswhere() -> Generator[VisualStudioInstallation, N '-format', 'json', '-products', '*', '-requires', 'Microsoft.VisualStudio.Component.VC.Tools.x86.x64', - '-requires', 'Microsoft.VisualStudio.Component.Windows10SDK' + '-requires', 'Microsoft.VisualStudio.Component.Windows10SDK', + '-utf8' ]).decode(errors='ignore') for install in json.loads(output): |