diff options
| author | bors-servo <infra@servo.org> | 2023-05-21 04:05:58 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-05-21 04:05:58 +0200 |
| commit | 1bb713521bc2f92526429622fa2da13d10f65200 (patch) | |
| tree | 52ff0d386ba21dda1bc5a7e039f323ece2a5fccd /python/servo/devenv_commands.py | |
| parent | 608b1d17a9c57938a9b370fd40f253d3afabee2c (diff) | |
| parent | dcf02caf81284246d8fd6ee4a09161733bd9310a (diff) | |
| download | servo-1bb713521bc2f92526429622fa2da13d10f65200.tar.gz servo-1bb713521bc2f92526429622fa2da13d10f65200.zip | |
Auto merge of #29374 - jdm:get-cx-cleanup, r=mrobinson
Assert if DomObject::global is called outside of a JS realm
To avoid crashing in https://github.com/servo/servo/issues/27037, we need to progressively add `InRealm` or `AlreadyInRealm` arguments higher up in the call stack. These changes assert that DomObject::global is only called inside of a realm, which is preferable to segfaulting in the JS engine. Making this a compile-time error requires changing lots of `.global()` callsites, but this PR removes a bunch that are now unnecessary.
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix (partially) #27037
- [x] There are tests for these changes
Diffstat (limited to 'python/servo/devenv_commands.py')
0 files changed, 0 insertions, 0 deletions