diff options
author | Emilio Cobos Álvarez <emilio@crisal.io> | 2023-05-30 20:41:21 +0200 |
---|---|---|
committer | Oriol Brufau <obrufau@igalia.com> | 2023-05-31 00:50:34 +0200 |
commit | f70b0e7108a68420840e93938aeb55c0bccca885 (patch) | |
tree | 215060b407fe7de8f7623ae804f7db1d4595c96e /components/style/servo/media_queries.rs | |
parent | c3322938f2b3d6f48dfc0b2049b8016a91d16ba4 (diff) | |
download | servo-f70b0e7108a68420840e93938aeb55c0bccca885.tar.gz servo-f70b0e7108a68420840e93938aeb55c0bccca885.zip |
style: Make Canvas/CanvasText and Link colors color-scheme-aware
For that, add `.dark` version of the browser.display* prefs that control
the light version of these colors.
The default for background/foreground colors are taken from the
GenericDarkColors used in LookAndFeel.
The defaults for links are based on this discussion:
https://github.com/whatwg/html/issues/5426#issuecomment-904021675
(So they effectively match Chrome).
Whether the dark colors should be exposed in about:preferences (like the
light colors are) is TBD.
With this patch, we pass all the tests in:
/html/semantics/document-metadata/the-meta-element/color-scheme/
Use the colors to paint the default canvas background and the default
colors.
There are three "regressions", though they are really progressions: we
now render the reference as the test expects (before we rendered a light
canvas background even for the reference).
Apart of these iframe tests (which we should look into, I filed
https://bugzilla.mozilla.org/show_bug.cgi?id=1738380), there are three
remaining test failures.
Two of them are due to `color: initial` not changing based on the
color-scheme. Safari also fails these tests, and the thing they're
really testing is whether system colors are preserved at computed-value
time:
https://github.com/w3c/csswg-drafts/issues/3847
Regarding that change, I'm not so sure the trade-offs there are worth
it, as that not only complicates interpolation (we wouldn't be able to
use system colors in color-mix among others, see
https://github.com/w3c/csswg-drafts/issues/5780) plus it changes
inheritance behavior in sorta unexpected ways, see:
https://github.com/w3c/csswg-drafts/issues/6773
Which I just filed because apparently no browser implements this
correctly. So for now will punt on those (keep matching Safari).
There's an svg-as-image test:
https://searchfox.org/mozilla-central/rev/f8576fec48d866c5f988baaf1fa8d2f8cce2a82f/testing/web-platform/tests/css/css-color-adjust/rendering/dark-color-scheme/svg-as-image.html
Which isn't using the feature at all and I'm not sure why is it supposed
to pass (why prefers-color-scheme: dark is supposed to match that SVG
image). This test fails in all browsers apparently:
https://wpt.fyi/results/css/css-color-adjust/rendering/dark-color-scheme/svg-as-image.html?label=master&label=experimental&aligned
I sent https://github.com/web-platform-tests/wpt/pull/31407 to remove
it and hopefully get it reviewed by some Chromium folks.
Differential Revision: https://phabricator.services.mozilla.com/D129746
Diffstat (limited to 'components/style/servo/media_queries.rs')
0 files changed, 0 insertions, 0 deletions