diff options
author | Delan Azabani <dazabani@igalia.com> | 2024-11-22 21:31:00 +0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-11-22 13:31:00 +0000 |
commit | 3a32af0c852fc14571a59b0ef2d3820317fed4ab (patch) | |
tree | 8c810fe3d01197ee87cda9e7414de6cbf3a06c86 /components/shared/profile | |
parent | fd3af6ad04d9e1e1acf6c36da9327ff79fcde8d4 (diff) | |
download | servo-3a32af0c852fc14571a59b0ef2d3820317fed4ab.tar.gz servo-3a32af0c852fc14571a59b0ef2d3820317fed4ab.zip |
Plumb URL into interval profiler tracing events (#34337)
Signed-off-by: Delan Azabani <dazabani@igalia.com>
Diffstat (limited to 'components/shared/profile')
-rw-r--r-- | components/shared/profile/lib.rs | 9 | ||||
-rw-r--r-- | components/shared/profile/time.rs | 6 |
2 files changed, 13 insertions, 2 deletions
diff --git a/components/shared/profile/lib.rs b/components/shared/profile/lib.rs index fef2b255bea..4e3aa1fc35d 100644 --- a/components/shared/profile/lib.rs +++ b/components/shared/profile/lib.rs @@ -18,10 +18,15 @@ pub mod time; #[macro_export] macro_rules! time_profile { ($category:expr, $meta:expr, $profiler_chan:expr, $($callback:tt)+) => {{ + let meta: Option<$crate::time::TimerMetadata> = $meta; #[cfg(feature = "tracing")] - let span = tracing::info_span!($category.variant_name(), servo_profiling = true); + let span = tracing::info_span!( + $category.variant_name(), + servo_profiling = true, + url = meta.as_ref().map(|m| m.url.clone()), + ); #[cfg(not(feature = "tracing"))] let span = (); - $crate::time::profile($category, $meta, $profiler_chan, span, $($callback)+) + $crate::time::profile($category, meta, $profiler_chan, span, $($callback)+) }}; } diff --git a/components/shared/profile/time.rs b/components/shared/profile/time.rs index ef36478e9ea..de7b6d2332c 100644 --- a/components/shared/profile/time.rs +++ b/components/shared/profile/time.rs @@ -55,10 +55,16 @@ pub enum ProfilerMsg { Exit(IpcSender<()>), } +/// Usage sites of variants marked “Rust tracing only” are not visible to rust-analyzer. #[repr(u32)] #[derive(Clone, Copy, Debug, Deserialize, Eq, Hash, Ord, PartialEq, PartialOrd, Serialize)] pub enum ProfilerCategory { + /// The compositor is rasterising or presenting. + /// + /// Not associated with a specific URL. Compositing = 0x00, + + /// The script thread is doing layout work. LayoutPerform = 0x10, /// Events currently only used by Layout 2013. |