diff options
| author | Xidorn Quan <me@upsuper.org> | 2018-05-02 21:07:07 +1000 |
|---|---|---|
| committer | Emilio Cobos Álvarez <emilio@crisal.io> | 2018-05-05 16:22:47 +0200 |
| commit | 09b22ab2dc264cf22647c273ed1c94cdd865f7df (patch) | |
| tree | 48a2a199f50adc34a3ae1258768f3c483fa36448 /components/selectors/bloom.rs | |
| parent | 12913d048f402c3516a299ac2fab3d66bddcdc6a (diff) | |
| download | servo-09b22ab2dc264cf22647c273ed1c94cdd865f7df.tar.gz servo-09b22ab2dc264cf22647c273ed1c94cdd865f7df.zip | |
style: Allow 16% false positives in test bloom::create_and_insert_some_stuff.
It seems that the result of hash algorithm used in bloom filter depends
on the pointer length. On 64bit platforms, there are 135 false positives
in the first part of that test, and 8 in the second part. However, on
32bit platforms, the numbers become 157 and 16 correspondingly.
16 is still less than 20% in the second part, so all fine, but 157 is
slightly larger than 15% in the test assertion. Given it is what we are
shipping, we probably should just accept this and loosen the assertion.
Bug: 1457524
Reviewed-by: heycam
MozReview-Commit-ID: 9kFXBzLFAzE
Diffstat (limited to 'components/selectors/bloom.rs')
| -rw-r--r-- | components/selectors/bloom.rs | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/components/selectors/bloom.rs b/components/selectors/bloom.rs index e06649d73bf..e4cd0a77f98 100644 --- a/components/selectors/bloom.rs +++ b/components/selectors/bloom.rs @@ -335,7 +335,7 @@ fn create_and_insert_some_stuff() { let false_positives = (1001_usize..2000).filter(|i| bf.might_contain(i)).count(); - assert!(false_positives < 150, "{} is not < 150", false_positives); // 15%. + assert!(false_positives < 160, "{} is not < 160", false_positives); // 16%. for i in 0_usize..100 { bf.remove(&i); |