diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2019-02-27 02:20:30 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-02-27 02:20:30 -0500 |
commit | ec7a5f21c85d539cc8de58ea702ce5f8ffda0949 (patch) | |
tree | 4c14278f1b5ffecbf2d5fc70c33a236f3af8784f /components/script | |
parent | be3ecc5dc1105c4c02fb5d8f9b33426871c10d06 (diff) | |
parent | c9087013b1bce87302ff49de9c2753262008c59b (diff) | |
download | servo-ec7a5f21c85d539cc8de58ea702ce5f8ffda0949.tar.gz servo-ec7a5f21c85d539cc8de58ea702ce5f8ffda0949.zip |
Auto merge of #22938 - asajeffrey:webvr-future-frame-data, r=paulrouget
Use webvr future_frame_data to avoid blocking the WebGL thread
<!-- Please describe your changes on the following line: -->
This PR fixes a potential deadlock caused by the WebGL thread being blocked on a VR device. Rather than blocking on the VR device, it forwards a future to the script thread, and then then script thread blocks.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because it's fixing a potential deadlock
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22938)
<!-- Reviewable:end -->
Diffstat (limited to 'components/script')
-rw-r--r-- | components/script/dom/vrdisplay.rs | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/components/script/dom/vrdisplay.rs b/components/script/dom/vrdisplay.rs index dd8f29195b7..e806afb7a22 100644 --- a/components/script/dom/vrdisplay.rs +++ b/components/script/dom/vrdisplay.rs @@ -42,13 +42,13 @@ use crossbeam_channel::{unbounded, Sender}; use dom_struct::dom_struct; use ipc_channel::ipc::IpcSender; use profile_traits::ipc; -use serde_bytes::ByteBuf; use std::cell::Cell; use std::mem; use std::ops::Deref; use std::rc::Rc; use std::thread; -use webvr_traits::{WebVRDisplayData, WebVRDisplayEvent, WebVRFrameData, WebVRLayer, WebVRMsg}; +use webvr_traits::{WebVRDisplayData, WebVRDisplayEvent, WebVRFrameData, WebVRFutureFrameData}; +use webvr_traits::{WebVRLayer, WebVRMsg}; #[dom_struct] pub struct VRDisplay { @@ -77,7 +77,7 @@ pub struct VRDisplay { // Compositor VRFrameData synchonization frame_data_status: Cell<VRFrameDataStatus>, #[ignore_malloc_size_of = "closures are hard"] - frame_data_receiver: DomRefCell<Option<WebGLReceiver<Result<ByteBuf, ()>>>>, + frame_data_receiver: DomRefCell<Option<WebGLReceiver<Result<WebVRFutureFrameData, ()>>>>, running_display_raf: Cell<bool>, paused: Cell<bool>, stopped_on_pause: Cell<bool>, @@ -664,8 +664,8 @@ impl VRDisplay { fn sync_frame_data(&self) { let status = if let Some(receiver) = self.frame_data_receiver.borrow().as_ref() { match receiver.recv().unwrap() { - Ok(bytes) => { - *self.frame_data.borrow_mut() = WebVRFrameData::from_bytes(&bytes[..]); + Ok(future_data) => { + *self.frame_data.borrow_mut() = future_data.block(); VRFrameDataStatus::Synced }, Err(()) => VRFrameDataStatus::Exit, |