diff options
author | Emilio Cobos Álvarez <emilio@crisal.io> | 2018-09-03 13:07:04 +0200 |
---|---|---|
committer | Emilio Cobos Álvarez <emilio@crisal.io> | 2018-09-03 13:09:10 +0200 |
commit | 5d8545d2b4a0dca7f18e1be9023ab0d36d47a33c (patch) | |
tree | a54504c97c741455ed46629ce2d602c114d142a7 /components/script | |
parent | 6d43bf78bc5e2a0c41206dfaa93be6d6c4af527f (diff) | |
download | servo-5d8545d2b4a0dca7f18e1be9023ab0d36d47a33c.tar.gz servo-5d8545d2b4a0dca7f18e1be9023ab0d36d47a33c.zip |
Fix other parts of the Servo build.
Diffstat (limited to 'components/script')
-rw-r--r-- | components/script/dom/css.rs | 2 | ||||
-rw-r--r-- | components/script/dom/cssmediarule.rs | 1 | ||||
-rw-r--r-- | components/script/dom/csssupportsrule.rs | 1 | ||||
-rw-r--r-- | components/script/dom/htmlimageelement.rs | 19 | ||||
-rw-r--r-- | components/script/dom/htmllinkelement.rs | 1 | ||||
-rw-r--r-- | components/script/dom/htmlstyleelement.rs | 1 | ||||
-rw-r--r-- | components/script/dom/medialist.rs | 3 | ||||
-rw-r--r-- | components/script/dom/window.rs | 1 |
8 files changed, 24 insertions, 5 deletions
diff --git a/components/script/dom/css.rs b/components/script/dom/css.rs index d642b44a19f..7a42d6b6e68 100644 --- a/components/script/dom/css.rs +++ b/components/script/dom/css.rs @@ -44,6 +44,7 @@ impl CSS { ParsingMode::DEFAULT, QuirksMode::NoQuirks, None, + None, ); decl.eval(&context) } @@ -61,6 +62,7 @@ impl CSS { ParsingMode::DEFAULT, QuirksMode::NoQuirks, None, + None, ); cond.eval(&context) } else { diff --git a/components/script/dom/cssmediarule.rs b/components/script/dom/cssmediarule.rs index 23f3c46a251..ccc803e4b42 100644 --- a/components/script/dom/cssmediarule.rs +++ b/components/script/dom/cssmediarule.rs @@ -81,6 +81,7 @@ impl CSSMediaRule { ParsingMode::DEFAULT, quirks_mode, window.css_error_reporter(), + None, ); let new_medialist = StyleMediaList::parse(&context, &mut input); diff --git a/components/script/dom/csssupportsrule.rs b/components/script/dom/csssupportsrule.rs index a96cd706b86..8b66fbe76cf 100644 --- a/components/script/dom/csssupportsrule.rs +++ b/components/script/dom/csssupportsrule.rs @@ -69,6 +69,7 @@ impl CSSSupportsRule { ParsingMode::DEFAULT, quirks_mode, None, + None, ); let enabled = cond.eval(&context); let mut guard = self.cssconditionrule.shared_lock().write(); diff --git a/components/script/dom/htmlimageelement.rs b/components/script/dom/htmlimageelement.rs index 62523e61f4e..3aaa7c579cb 100644 --- a/components/script/dom/htmlimageelement.rs +++ b/components/script/dom/htmlimageelement.rs @@ -538,12 +538,17 @@ impl HTMLImageElement { /// https://html.spec.whatwg.org/multipage/#matches-the-environment fn matches_environment(&self, media_query: String) -> bool { let document = document_from_node(self); - let device = document.device(); - if !device.is_some() { - return false; - } + let device = match document.device() { + Some(device) => device, + None => return false, + }; let quirks_mode = document.quirks_mode(); let document_url = &document.url(); + // FIXME(emilio): This should do the same that we do for other media + // lists regarding the rule type and such, though it doesn't really + // matter right now... + // + // Also, ParsingMode::all() is wrong, and should be DEFAULT. let context = ParserContext::new( Origin::Author, document_url, @@ -551,11 +556,12 @@ impl HTMLImageElement { ParsingMode::all(), quirks_mode, None, + None, ); let mut parserInput = ParserInput::new(&media_query); let mut parser = Parser::new(&mut parserInput); let media_list = MediaList::parse(&context, &mut parser); - media_list.evaluate(&device.unwrap(), quirks_mode) + media_list.evaluate(&device, quirks_mode) } /// <https://html.spec.whatwg.org/multipage/#normalise-the-source-densities> @@ -1039,9 +1045,12 @@ pub fn parse_a_sizes_attribute(value: DOMString) -> SourceSizeList { Origin::Author, &url, Some(CssRuleType::Style), + // FIXME(emilio): why ::empty() instead of ::DEFAULT? Also, what do + // browsers do regarding quirks-mode in a media list? ParsingMode::empty(), QuirksMode::NoQuirks, None, + None, ); SourceSizeList::parse(&context, &mut parser) } diff --git a/components/script/dom/htmllinkelement.rs b/components/script/dom/htmllinkelement.rs index a86789dcd71..be7b2785ee9 100644 --- a/components/script/dom/htmllinkelement.rs +++ b/components/script/dom/htmllinkelement.rs @@ -287,6 +287,7 @@ impl HTMLLinkElement { ParsingMode::DEFAULT, document.quirks_mode(), window.css_error_reporter(), + None, ); let media = MediaList::parse(&context, &mut css_parser); diff --git a/components/script/dom/htmlstyleelement.rs b/components/script/dom/htmlstyleelement.rs index 82da9ba6180..bcecab9088b 100644 --- a/components/script/dom/htmlstyleelement.rs +++ b/components/script/dom/htmlstyleelement.rs @@ -91,6 +91,7 @@ impl HTMLStyleElement { ParsingMode::DEFAULT, doc.quirks_mode(), css_error_reporter, + None, ); let shared_lock = node.owner_doc().style_shared_lock().clone(); let mut input = ParserInput::new(&mq_str); diff --git a/components/script/dom/medialist.rs b/components/script/dom/medialist.rs index d43f6d3a710..99800f1beb1 100644 --- a/components/script/dom/medialist.rs +++ b/components/script/dom/medialist.rs @@ -83,6 +83,7 @@ impl MediaListMethods for MediaList { ParsingMode::DEFAULT, quirks_mode, window.css_error_reporter(), + None, ); *media_queries = StyleMediaList::parse(&context, &mut parser); } @@ -123,6 +124,7 @@ impl MediaListMethods for MediaList { ParsingMode::DEFAULT, quirks_mode, win.css_error_reporter(), + None, ); let m = MediaQuery::parse(&context, &mut parser); // Step 2 @@ -156,6 +158,7 @@ impl MediaListMethods for MediaList { ParsingMode::DEFAULT, quirks_mode, win.css_error_reporter(), + None, ); let m = MediaQuery::parse(&context, &mut parser); // Step 2 diff --git a/components/script/dom/window.rs b/components/script/dom/window.rs index e125aa87fd9..7ccd828f9e3 100644 --- a/components/script/dom/window.rs +++ b/components/script/dom/window.rs @@ -1089,6 +1089,7 @@ impl WindowMethods for Window { ParsingMode::DEFAULT, quirks_mode, self.css_error_reporter(), + None, ); let media_query_list = media_queries::MediaList::parse(&context, &mut parser); |