aboutsummaryrefslogtreecommitdiffstats
path: root/components/script
diff options
context:
space:
mode:
authorbors-servo <lbergstrom+bors@mozilla.com>2017-02-23 16:01:16 -0800
committerGitHub <noreply@github.com>2017-02-23 16:01:16 -0800
commit1d13e6a2df42af3cce427a0b2062ac70d28c05d0 (patch)
treedb65931c394383ff558618d883f657839fd9a94e /components/script
parent6c9e94b1c07dd148430d175e79c595db82dea742 (diff)
parent30ff2f8f0d37bb85e568cacaeac871458e4078ff (diff)
downloadservo-1d13e6a2df42af3cce427a0b2062ac70d28c05d0.tar.gz
servo-1d13e6a2df42af3cce427a0b2062ac70d28c05d0.zip
Auto merge of #15700 - glennw:zoom-wip-2, r=mbrubeck
Introduce CSSPixel as a replacement for ViewportPx and PagePx. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15700) <!-- Reviewable:end -->
Diffstat (limited to 'components/script')
-rw-r--r--components/script/dom/document.rs4
-rw-r--r--components/script/dom/mediaquerylist.rs11
-rw-r--r--components/script/dom/window.rs4
3 files changed, 7 insertions, 12 deletions
diff --git a/components/script/dom/document.rs b/components/script/dom/document.rs
index c836a46f1da..4b693f0448d 100644
--- a/components/script/dom/document.rs
+++ b/components/script/dom/document.rs
@@ -3252,7 +3252,7 @@ impl DocumentMethods for Document {
let y = *y as f32;
let point = &Point2D::new(x, y);
let window = window_from_node(self);
- let viewport = window.window_size().unwrap().visible_viewport;
+ let viewport = window.window_size().unwrap().initial_viewport;
if self.browsing_context().is_none() {
return None;
@@ -3285,7 +3285,7 @@ impl DocumentMethods for Document {
let y = *y as f32;
let point = &Point2D::new(x, y);
let window = window_from_node(self);
- let viewport = window.window_size().unwrap().visible_viewport;
+ let viewport = window.window_size().unwrap().initial_viewport;
if self.browsing_context().is_none() {
return vec!();
diff --git a/components/script/dom/mediaquerylist.rs b/components/script/dom/mediaquerylist.rs
index 2545b911c7a..486f9f64fd3 100644
--- a/components/script/dom/mediaquerylist.rs
+++ b/components/script/dom/mediaquerylist.rs
@@ -18,12 +18,11 @@ use dom::document::Document;
use dom::event::Event;
use dom::eventtarget::EventTarget;
use dom::mediaquerylistevent::MediaQueryListEvent;
-use euclid::scale_factor::ScaleFactor;
use js::jsapi::JSTracer;
use std::cell::Cell;
use std::rc::Rc;
use style::media_queries::{Device, MediaList, MediaType};
-use style_traits::{PagePx, ToCss, ViewportPx};
+use style_traits::ToCss;
pub enum MediaQueryListMatchState {
Same(bool),
@@ -75,12 +74,8 @@ impl MediaQueryList {
pub fn evaluate(&self) -> bool {
if let Some(window_size) = self.document.window().window_size() {
- let viewport_size = window_size.visible_viewport;
- // TODO: support real ViewportPx, including zoom level
- // This information seems not to be tracked currently, so we assume
- // ViewportPx == PagePx
- let page_to_viewport: ScaleFactor<f32, PagePx, ViewportPx> = ScaleFactor::new(1.0);
- let device = Device::new(MediaType::Screen, viewport_size * page_to_viewport);
+ let viewport_size = window_size.initial_viewport;
+ let device = Device::new(MediaType::Screen, viewport_size);
self.media_query_list.evaluate(&device)
} else {
false
diff --git a/components/script/dom/window.rs b/components/script/dom/window.rs
index 93cdd1c31d0..919093c158c 100644
--- a/components/script/dom/window.rs
+++ b/components/script/dom/window.rs
@@ -774,7 +774,7 @@ impl WindowMethods for Window {
//TODO Include Scrollbar
fn InnerHeight(&self) -> i32 {
self.window_size.get()
- .and_then(|e| e.visible_viewport.height.to_i32())
+ .and_then(|e| e.initial_viewport.height.to_i32())
.unwrap_or(0)
}
@@ -782,7 +782,7 @@ impl WindowMethods for Window {
//TODO Include Scrollbar
fn InnerWidth(&self) -> i32 {
self.window_size.get()
- .and_then(|e| e.visible_viewport.width.to_i32())
+ .and_then(|e| e.initial_viewport.width.to_i32())
.unwrap_or(0)
}