aboutsummaryrefslogtreecommitdiffstats
path: root/components/script
diff options
context:
space:
mode:
authorSimon Wülker <simon.wuelker@arcor.de>2025-01-30 09:47:21 +0100
committerGitHub <noreply@github.com>2025-01-30 08:47:21 +0000
commit1ad45a776a8055a85cdefbbae84e1359ba7077cd (patch)
treef12a0a5e3a7c31a0140771bc348f643f508e1684 /components/script
parent6de0331d7ccb04fe8d2334580b7355647bb6d07d (diff)
downloadservo-1ad45a776a8055a85cdefbbae84e1359ba7077cd.tar.gz
servo-1ad45a776a8055a85cdefbbae84e1359ba7077cd.zip
Potentially signal a slot change in Node::insert (#35221)
* Potentially signal a slot change in Node::insert Signed-off-by: Simon Wülker <simon.wuelker@arcor.de> * Update WPT expectations Signed-off-by: Simon Wülker <simon.wuelker@arcor.de> --------- Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
Diffstat (limited to 'components/script')
-rw-r--r--components/script/dom/node.rs29
1 files changed, 28 insertions, 1 deletions
diff --git a/components/script/dom/node.rs b/components/script/dom/node.rs
index 30b15daab05..e6db3eaa9d0 100644
--- a/components/script/dom/node.rs
+++ b/components/script/dom/node.rs
@@ -60,6 +60,7 @@ use crate::dom::bindings::codegen::Bindings::NodeBinding::{
use crate::dom::bindings::codegen::Bindings::NodeListBinding::NodeListMethods;
use crate::dom::bindings::codegen::Bindings::ProcessingInstructionBinding::ProcessingInstructionMethods;
use crate::dom::bindings::codegen::Bindings::ShadowRootBinding::ShadowRoot_Binding::ShadowRootMethods;
+use crate::dom::bindings::codegen::Bindings::ShadowRootBinding::SlotAssignmentMode;
use crate::dom::bindings::codegen::Bindings::WindowBinding::WindowMethods;
use crate::dom::bindings::codegen::InheritTypes::DocumentFragmentTypeId;
use crate::dom::bindings::codegen::UnionTypes::NodeOrString;
@@ -91,7 +92,7 @@ use crate::dom::htmliframeelement::{HTMLIFrameElement, HTMLIFrameElementLayoutMe
use crate::dom::htmlimageelement::{HTMLImageElement, LayoutHTMLImageElementHelpers};
use crate::dom::htmlinputelement::{HTMLInputElement, LayoutHTMLInputElementHelpers};
use crate::dom::htmllinkelement::HTMLLinkElement;
-use crate::dom::htmlslotelement::HTMLSlotElement;
+use crate::dom::htmlslotelement::{HTMLSlotElement, Slottable};
use crate::dom::htmlstyleelement::HTMLStyleElement;
use crate::dom::htmltextareaelement::{HTMLTextAreaElement, LayoutHTMLTextAreaElementHelpers};
use crate::dom::htmlvideoelement::{HTMLVideoElement, LayoutHTMLVideoElementHelpers};
@@ -2149,6 +2150,32 @@ impl Node {
// Step 7.1.
parent.add_child(kid, child);
+ // Step 7.4 If parent is a shadow host whose shadow root’s slot assignment is "named"
+ // and node is a slottable, then assign a slot for node.
+ if let Some(shadow_root) = parent.downcast::<Element>().and_then(Element::shadow_root) {
+ if shadow_root.SlotAssignment() == SlotAssignmentMode::Named {
+ let cx = GlobalScope::get_cx();
+ if let Some(element) = node.downcast::<Element>() {
+ rooted!(in(*cx) let slottable = Slottable::Element(Dom::from_ref(element)));
+ slottable.assign_a_slot();
+ }
+ if let Some(text) = node.downcast::<Text>() {
+ rooted!(in(*cx) let slottable = Slottable::Text(Dom::from_ref(text)));
+ slottable.assign_a_slot();
+ }
+ }
+ }
+
+ // Step 7.5 If parent’s root is a shadow root, and parent is a slot whose assigned nodes
+ // is the empty list, then run signal a slot change for parent.
+ if parent.is_in_a_shadow_tree() {
+ if let Some(slot_element) = parent.downcast::<HTMLSlotElement>() {
+ if !slot_element.has_assigned_nodes() {
+ ScriptThread::signal_a_slot_change(slot_element);
+ }
+ }
+ }
+
// Step 7.6 Run assign slottables for a tree with node’s root.
kid.GetRootNode(&GetRootNodeOptions::empty())
.assign_slottables_for_a_tree();