diff options
| author | bors-servo <lbergstrom+bors@mozilla.com> | 2016-11-12 09:58:29 -0600 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2016-11-12 09:58:29 -0600 |
| commit | f04033a13972faea9efd9689e6949406241ca85f (patch) | |
| tree | d0e2da1e32ee2b28d06e63617cf790092261d038 /components/script/textinput.rs | |
| parent | 579ab2d99cd8c07a31c3b68a4659c484d5189ada (diff) | |
| parent | 319153640ca11a386df944dafc45ab1f18192534 (diff) | |
| download | servo-f04033a13972faea9efd9689e6949406241ca85f.tar.gz servo-f04033a13972faea9efd9689e6949406241ca85f.zip | |
Auto merge of #14184 - jmcomets:tab-no-default-action, r=metajack
Return `KeyReaction::Nothing` for a Tab event
Do nothing instead of triggering the default action for a tab event.
Hitting the tab key in an html text input shouldn't submit the form, and for any text input, the tab key should have a particular action associated, not the default action.
This cleans up #12701.
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14184)
<!-- Reviewable:end -->
Diffstat (limited to 'components/script/textinput.rs')
| -rw-r--r-- | components/script/textinput.rs | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/components/script/textinput.rs b/components/script/textinput.rs index 25243d739ab..5f04b5b187e 100644 --- a/components/script/textinput.rs +++ b/components/script/textinput.rs @@ -544,7 +544,6 @@ impl<T: ClipboardProvider> TextInput<T> { self.adjust_vertical(28, maybe_select); KeyReaction::RedrawSelection } - (None, Key::Tab) => KeyReaction::TriggerDefaultAction, _ => KeyReaction::Nothing, } } |