diff options
| author | bors-servo <lbergstrom+bors@mozilla.com> | 2017-11-11 08:59:20 -0600 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-11-11 08:59:20 -0600 |
| commit | 9d055522d355b711c7837ba5997089ba8a7641ae (patch) | |
| tree | 16a909fed12d2c183ce4776d6bd04c794208d66c /components/script/stylesheet_loader.rs | |
| parent | 33fa728d6e5392993c83f630acc1d6e442104dec (diff) | |
| parent | 2974dae4315420d1e7252029c2c30198ea62ac61 (diff) | |
| download | servo-9d055522d355b711c7837ba5997089ba8a7641ae.tar.gz servo-9d055522d355b711c7837ba5997089ba8a7641ae.zip | |
Auto merge of #19180 - ferjm:optional.overloaded.webidl, r=jdm
Fix binding generation for overloaded functions with optionals and de…
…fault values
The generated bindings for an interface like this:
```webidl
void someFunction(Foo foo, optional long a = 0, optional long b = 1);
void someFunction(Bar bar, optional long a = 0);
```
are failing to build with an error like:
```bash
error[E0425]: cannot find function `Throw` in this scope
--> /Users/ferjm/dev/mozilla/servo/target/debug/build/script-7b1a12ddd08207e3/out/Bindings/TestBindingBinding.rs:15395:24
|
15395 | return Throw(cx, NS_ERROR_XPC_BAD_CONVERT_JS);
| ^^^^^ not found in this scope
error[E0425]: cannot find value `NS_ERROR_XPC_BAD_CONVERT_JS` in this scope
--> /Users/ferjm/dev/mozilla/servo/target/debug/build/script-7b1a12ddd08207e3/out/Bindings/TestBindingBinding.rs:15395:34
|
15395 | return Throw(cx, NS_ERROR_XPC_BAD_CONVERT_JS);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ not found in this scope
error[E0425]: cannot find function `Throw` in this scope
--> /Users/ferjm/dev/mozilla/servo/target/debug/build/script-7b1a12ddd08207e3/out/Bindings/TestBindingBinding.rs:15468:24
|
15468 | return Throw(cx, NS_ERROR_XPC_BAD_CONVERT_JS);
| ^^^^^ not found in this scope
error[E0425]: cannot find value `NS_ERROR_XPC_BAD_CONVERT_JS` in this scope
--> /Users/ferjm/dev/mozilla/servo/target/debug/build/script-7b1a12ddd08207e3/out/Bindings/TestBindingBinding.rs:15468:34
|
15468 | return Throw(cx, NS_ERROR_XPC_BAD_CONVERT_JS);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ not found in this scope
error: aborting due to 4 previous errors
error: Could not compile `script`.
```
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] There are tests for these changes
** Note that this depends** on https://github.com/servo/rust-mozjs/pull/379
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19180)
<!-- Reviewable:end -->
Diffstat (limited to 'components/script/stylesheet_loader.rs')
0 files changed, 0 insertions, 0 deletions