diff options
| author | Josh Matthews <josh@joshmatthews.net> | 2025-04-04 02:45:08 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-04-04 06:45:08 +0000 |
| commit | b4079b3ff33a3f7e2b35ac3aacc4467f8da42242 (patch) | |
| tree | af6ae87af10c1383a3a3fcdb28b1d2544bc2fc45 /components/script/lib.rs | |
| parent | 277c0b82dd4411798b461a4e3a782e7869ae5740 (diff) | |
| download | servo-b4079b3ff33a3f7e2b35ac3aacc4467f8da42242.tar.gz servo-b4079b3ff33a3f7e2b35ac3aacc4467f8da42242.zip | |
Move generated bindings to script_bindings (#36323)
This is the final step of #1799, where the majority of the generated
code for the JS bindings is now compiled as part of the script_bindings
build step. The remaining pieces in script must live there because they
refer to concrete DOM types; all code in script_bindings is generic over
the
[DomTypes](https://doc.servo.org/script/dom/bindings/codegen/DomTypes/trait.DomTypes.html)
trait.
My testing with incremental builds shows me a 12 second reduction in
build times on my 2024 M4 Macbook Pro when modifying code in the script
crate after these changes. Before this PR those changes took 20 seconds
to rebuild Servo, and now they take 8 seconds.
Testing: Existing WPT tests ensure no regressions.
Fixes: #1799
---------
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
Diffstat (limited to 'components/script/lib.rs')
| -rw-r--r-- | components/script/lib.rs | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/components/script/lib.rs b/components/script/lib.rs index b2ade0330c9..7a866f1c7b2 100644 --- a/components/script/lib.rs +++ b/components/script/lib.rs @@ -45,13 +45,11 @@ pub(crate) mod document_collection; pub(crate) mod iframe_collection; pub(crate) mod image_animation; pub mod layout_dom; -mod mem; #[allow(unsafe_code)] pub(crate) mod messaging; mod microtask; mod navigation; mod network_listener; -#[allow(dead_code)] mod realms; mod routed_promise; #[allow(dead_code)] @@ -82,12 +80,12 @@ mod xpath; mod svgpath; pub use init::init; +pub(crate) use script_bindings::DomTypes; pub use script_runtime::JSEngineSetup; pub use script_thread::ScriptThread; pub use serviceworker_manager::ServiceWorkerManager; pub(crate) use crate::dom::bindings::codegen::DomTypeHolder::DomTypeHolder; -pub(crate) use crate::dom::bindings::codegen::DomTypes::DomTypes; // These trait exports are public, because they are used in the DOM bindings. // Since they are used in derive macros, // it is useful that they are accessible at the root of the crate. |