aboutsummaryrefslogtreecommitdiffstats
path: root/components/script/dom
diff options
context:
space:
mode:
authorbors-servo <metajack+bors@gmail.com>2015-07-27 05:57:09 -0600
committerbors-servo <metajack+bors@gmail.com>2015-07-27 05:57:09 -0600
commit5b90cfd57d2d4595596c37b7f441d3422391eb8d (patch)
tree5a620b609ace32b446130358050cad451cd71758 /components/script/dom
parent7c8922c0c39616559b580b4a363ebe2a8c6b3ba8 (diff)
parent632b7f3c588c3564809a0ff1d5f92f75fcd9e598 (diff)
downloadservo-5b90cfd57d2d4595596c37b7f441d3422391eb8d.tar.gz
servo-5b90cfd57d2d4595596c37b7f441d3422391eb8d.zip
Auto merge of #6773 - dzbarsky:which, r=Ms2ger
Fix MouseEvent.which to not throw <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6773) <!-- Reviewable:end -->
Diffstat (limited to 'components/script/dom')
-rw-r--r--components/script/dom/mouseevent.rs6
-rw-r--r--components/script/dom/webidls/MouseEvent.webidl1
2 files changed, 3 insertions, 4 deletions
diff --git a/components/script/dom/mouseevent.rs b/components/script/dom/mouseevent.rs
index 9e0b7119326..e51b8391ee0 100644
--- a/components/script/dom/mouseevent.rs
+++ b/components/script/dom/mouseevent.rs
@@ -160,11 +160,11 @@ impl<'a> MouseEventMethods for &'a MouseEvent {
// - https://github.com/servo/servo/issues/6643
// - https://bugzilla.mozilla.org/show_bug.cgi?id=1186125
// This returns the same result as current gecko.
- fn GetWhich(self) -> Fallible<i32> {
+ fn Which(self) -> i32 {
if opts::experimental_enabled() {
- Ok((self.button.get() + 1) as i32)
+ (self.button.get() + 1) as i32
} else {
- Err(NotSupported)
+ 0
}
}
diff --git a/components/script/dom/webidls/MouseEvent.webidl b/components/script/dom/webidls/MouseEvent.webidl
index be3abc86cdd..f9be1e64ed0 100644
--- a/components/script/dom/webidls/MouseEvent.webidl
+++ b/components/script/dom/webidls/MouseEvent.webidl
@@ -20,7 +20,6 @@ interface MouseEvent : UIEvent {
//readonly attribute unsigned short buttons;
//boolean getModifierState (DOMString keyArg);
- [Throws]
readonly attribute long which;
};