diff options
author | bors-servo <metajack+bors@gmail.com> | 2015-03-31 11:51:55 -0600 |
---|---|---|
committer | bors-servo <metajack+bors@gmail.com> | 2015-03-31 11:51:55 -0600 |
commit | 225d7d2ece418d5ecefd7ce9047c4754ffb68c73 (patch) | |
tree | 0fe5f849aea61e573e551b28a2956aacd8038f53 /components/script/dom | |
parent | ebdf1d494b6c986e6dfcb7d8fd3f0ffa126523ed (diff) | |
parent | c0e691b08dd8aeb2601245313a14d18e8ccb118a (diff) | |
download | servo-225d7d2ece418d5ecefd7ce9047c4754ffb68c73.tar.gz servo-225d7d2ece418d5ecefd7ce9047c4754ffb68c73.zip |
auto merge of #5457 : deokjinkim/servo/navigator_appversion, r=jdm
In my mistake, I close PR for this commit.
I'm sorry for inconvenience.
@jdm 's comment
The test expectations for /tests/wpt/web-platform-tests/html/dom/interfaces.html and /tests/wpt/web-platform-tests/workers/interfaces.workers.js will need to be updated - http://mxr.mozilla.org/servo/search?string=appversion
According to your guide, I revised commit. Is this your intention?
r? @jdm
cc @yichoi
Diffstat (limited to 'components/script/dom')
-rw-r--r-- | components/script/dom/navigator.rs | 4 | ||||
-rw-r--r-- | components/script/dom/navigatorinfo.rs | 4 | ||||
-rw-r--r-- | components/script/dom/webidls/Navigator.webidl | 2 | ||||
-rw-r--r-- | components/script/dom/workernavigator.rs | 4 |
4 files changed, 13 insertions, 1 deletions
diff --git a/components/script/dom/navigator.rs b/components/script/dom/navigator.rs index 257e1d2dfab..0b96e355a2f 100644 --- a/components/script/dom/navigator.rs +++ b/components/script/dom/navigator.rs @@ -54,5 +54,9 @@ impl<'a> NavigatorMethods for JSRef<'a, Navigator> { fn UserAgent(self) -> DOMString { navigatorinfo::UserAgent() } + + fn AppVersion(self) -> DOMString { + navigatorinfo::AppVersion() + } } diff --git a/components/script/dom/navigatorinfo.rs b/components/script/dom/navigatorinfo.rs index 7dc94d85374..d4aec6999ab 100644 --- a/components/script/dom/navigatorinfo.rs +++ b/components/script/dom/navigatorinfo.rs @@ -33,3 +33,7 @@ pub fn UserAgent() -> DOMString { None => "".to_owned(), } } + +pub fn AppVersion() -> DOMString { + "4.0".to_owned() +} diff --git a/components/script/dom/webidls/Navigator.webidl b/components/script/dom/webidls/Navigator.webidl index 0ce509f4c04..67b5cf95018 100644 --- a/components/script/dom/webidls/Navigator.webidl +++ b/components/script/dom/webidls/Navigator.webidl @@ -19,7 +19,7 @@ Navigator implements NavigatorID; interface NavigatorID { readonly attribute DOMString appCodeName; // constant "Mozilla" readonly attribute DOMString appName; - //readonly attribute DOMString appVersion; + readonly attribute DOMString appVersion; readonly attribute DOMString platform; readonly attribute DOMString product; // constant "Gecko" boolean taintEnabled(); // constant false diff --git a/components/script/dom/workernavigator.rs b/components/script/dom/workernavigator.rs index 40c74e78b38..ea446f986cb 100644 --- a/components/script/dom/workernavigator.rs +++ b/components/script/dom/workernavigator.rs @@ -55,5 +55,9 @@ impl<'a> WorkerNavigatorMethods for JSRef<'a, WorkerNavigator> { fn UserAgent(self) -> DOMString { navigatorinfo::UserAgent() } + + fn AppVersion(self) -> DOMString { + navigatorinfo::AppVersion() + } } |