diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2019-04-01 20:57:07 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-04-01 20:57:07 -0400 |
commit | c5da3306b2a5882d9e219fa935c1364a1afa1bc6 (patch) | |
tree | f1f2e2506486e80d4b030dcf55347ebea17fe3db /components/script/dom/xrview.rs | |
parent | 3340214a292df5121ac81ea9a63c6b6a565a060b (diff) | |
parent | a8995fbf1aab58eda9ecd1018d74734344daa5eb (diff) | |
download | servo-c5da3306b2a5882d9e219fa935c1364a1afa1bc6.tar.gz servo-c5da3306b2a5882d9e219fa935c1364a1afa1bc6.zip |
Auto merge of #23128 - kamal-umudlu:pass_not_none_value_in_setfullscreen, r=jdm
Pass not none value in setfullscreen
<!-- Please describe your changes on the following line: -->
# Diagnose
Entering fullscreen mode is passing `None` value to `Window` when `set_fullscreen` function is called which prevents
Servo actually entering fullscreen mode.
In addition, the function `exit_fullscreen` in `document.rs` is passing True value to
`SetFullscreenState` which doesn't allow to exit from fullscreen mode.
# Solution
1. Instead of passing `None` value when `FullScreenState` is true, `window.get_primary_monitor()` is called in order to pass a monitor id.
This fix make Servo actually enter fullscreen mode.
2. Changed `SetFullscreenState` to false when `exit_fullscreen` function is called.
3. In addition, added new implementation to support exiting from fullscreen mode by pressing `Escape` button.
# Testing Plan
After my change in [windows.rs and document.rs](https://github.com/kamal-umudlu/servo/commit/af6b5981541bd407fba8a0e9f4ea1713f7c6e25c),
the Servo app can enter/exit fullscreen mode.
In addition, the [`ESC button support`](https://github.com/kamal-umudlu/servo/commit/14ebd5bbb055d436a01756fd8fc0a5595e41332e)
allows to exit from fullscreenmode.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22853
<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23128)
<!-- Reviewable:end -->
Diffstat (limited to 'components/script/dom/xrview.rs')
0 files changed, 0 insertions, 0 deletions