aboutsummaryrefslogtreecommitdiffstats
path: root/components/script/dom/xrrenderstate.rs
diff options
context:
space:
mode:
authorJosh Matthews <josh@joshmatthews.net>2024-11-05 03:29:08 -0500
committerGitHub <noreply@github.com>2024-11-05 08:29:08 +0000
commit25a0764a37a585d032ca352923b24995f8cbf1a0 (patch)
tree1805edc4fc79396de9150f8bc063888926d53d3b /components/script/dom/xrrenderstate.rs
parent537958a3ccb57502c558e4da0963307fd7481a14 (diff)
downloadservo-25a0764a37a585d032ca352923b24995f8cbf1a0.tar.gz
servo-25a0764a37a585d032ca352923b24995f8cbf1a0.zip
Use out parameter for generated methods returning JSVal (#34087)
* Make generated bindings that return a WebIDL `any` value use out parameters. Returning raw JSVal values makes it easier to create GC hazards in code that calls these methods. Accepting a MutableHandle argument instead ensures that the values are rooted by the caller. Signed-off-by: Josh Matthews <josh@joshmatthews.net> * Update mozjs. Signed-off-by: Josh Matthews <josh@joshmatthews.net> * Fix clippy warnings. Signed-off-by: Josh Matthews <josh@joshmatthews.net> --------- Signed-off-by: Josh Matthews <josh@joshmatthews.net>
Diffstat (limited to 'components/script/dom/xrrenderstate.rs')
-rw-r--r--components/script/dom/xrrenderstate.rs6
1 files changed, 3 insertions, 3 deletions
diff --git a/components/script/dom/xrrenderstate.rs b/components/script/dom/xrrenderstate.rs
index cabe248d0a2..e189710ead2 100644
--- a/components/script/dom/xrrenderstate.rs
+++ b/components/script/dom/xrrenderstate.rs
@@ -5,7 +5,7 @@
use std::cell::Cell;
use dom_struct::dom_struct;
-use js::jsval::JSVal;
+use js::rust::MutableHandleValue;
use webxr_api::SubImages;
use crate::dom::bindings::cell::DomRefCell;
@@ -146,10 +146,10 @@ impl XRRenderStateMethods for XRRenderState {
}
/// <https://immersive-web.github.io/layers/#dom-xrrenderstate-layers>
- fn Layers(&self, cx: JSContext) -> JSVal {
+ fn Layers(&self, cx: JSContext, retval: MutableHandleValue) {
// TODO: cache this array?
let layers = self.layers.borrow();
let layers: Vec<&XRLayer> = layers.iter().map(|x| &**x).collect();
- to_frozen_array(&layers[..], cx)
+ to_frozen_array(&layers[..], cx, retval)
}
}